Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Ulrich Müller" <ulm@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit()
Date: Sun, 29 Aug 2021 21:27:20
Message-Id: a573e3d4e163538ee239030c8a6e5af6a6f47d65.camel@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit() by "Ulrich Müller"
1 On Sun, 2021-08-29 at 22:06 +0200, Ulrich Müller wrote:
2 > Bug: https://bugs.gentoo.org/399039
3 > Signed-off-by: Ulrich Müller <ulm@g.o>
4 > ---
5 > bin/ebuild.sh | 3 +--
6 > 1 file changed, 1 insertion(+), 2 deletions(-)
7 >
8 > diff --git a/bin/ebuild.sh b/bin/ebuild.sh
9 > index 1bca2c965..f5f3d9eec 100755
10 > --- a/bin/ebuild.sh
11 > +++ b/bin/ebuild.sh
12 > @@ -248,8 +248,7 @@ inherit() {
13 > # previous inherit call in the call stack.
14 > if [[ -n ${ECLASS} && -n ${!__export_funcs_var} ]] ; then
15 > eqawarn "QA Notice: EXPORT_FUNCTIONS is called before inherit in ${ECLASS}.eclass."
16 > - eqawarn "For compatibility with <=portage-2.1.6.7, only call EXPORT_FUNCTIONS"
17 > - eqawarn "after inherit(s)."
18 > + eqawarn "For compatibility with PMS, only call EXPORT_FUNCTIONS after inherit(s)."
19 > fi
20 > fi
21 >
22
23 Could you add a sentence that the current Portage behavior is going to
24 change in the future?
25
26
27 --
28 Best regards,
29 Michał Górny

Replies