Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] bin/eapi.sh: Invert condition in ___eapi_unpack_supports_absolute_paths().
Date: Mon, 16 Feb 2015 20:14:08
Message-Id: 54E24F8B.6080207@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] bin/eapi.sh: Invert condition in ___eapi_unpack_supports_absolute_paths(). by "Ulrich Müller"
1 On 02/16/2015 10:21 AM, Ulrich Müller wrote:
2 > This should return true starting with EAPI 6, and false for EAPI 5 and earlier.
3 > ---
4 > bin/eapi.sh | 2 +-
5 > 1 file changed, 1 insertion(+), 1 deletion(-)
6 >
7 > diff --git a/bin/eapi.sh b/bin/eapi.sh
8 > index f1c677e..528e6f2 100644
9 > --- a/bin/eapi.sh
10 > +++ b/bin/eapi.sh
11 > @@ -175,7 +175,7 @@ ___eapi_unpack_is_case_sensitive() {
12 > }
13 >
14 > ___eapi_unpack_supports_absolute_paths() {
15 > - [[ ${1-${EAPI-0}} =~ ^(0|1|2|3|4|4-python|4-slot-abi|5|5-hdepend)$ ]]
16 > + [[ ! ${1-${EAPI-0}} =~ ^(0|1|2|3|4|4-python|4-slot-abi|5|5-hdepend)$ ]]
17 > }
18 >
19 > ___eapi_die_can_respect_nonfatal() {
20 >
21
22 LGTM.
23
24 Please go ahead and push this. We want to make sure it's fixed for the
25 next release, since it's a sort of regression.
26 --
27 Thanks,
28 Zac