Re: [gentoo-portage-dev] PATCH: clean PORTAGE_TMPDIR (bugs 85803 and 105706)

[Zac Medico]

Brian Harring wrote:
> On Sun, Oct 30, 2005 at 04:33:28AM -0800, Zac Medico wrote:
>
>>http://bugs.gentoo.org/show_bug.cgi?id=85803
>>http://bugs.gentoo.org/show_bug.cgi?id=105706
>>
>>There are a few cases where unwanted directories are left behind in
>>PORTAGE_TMPDIR with varying amounts of files inside.  When packages are
>>merged this may occur with the --buildpkgonly option or with binary
>>packages.  It may also occur when a package ia unmerged.  The attached
>>patch should clean up all of these cases.  Feedback is appreciated.
>
>
> Correct the BUILDDIR misses in doebuild imo; this seems a bit like a
> bandaid over the fact doebuild's clean only cleanses ${T} .
>
> tag the shutil.rmtree into doebuild instead of adding a secondary
> function that must be used, is my opinion- tracing out cleanup and
> mydo == "clean" demonstrates where the miss is.
>
> ~harring


Indeed, metaphorically speaking, my patch _is_ a bandaid.  However, stable portage has many bandaids.  While this certainly in not the best long term solution, it seems to work quite well in the short term. ;)

I choose the bandaid method in order to keep the patch as small as possible and still keep PORTAGE_TMPDIR clean.  AFAICT it would take a *much* larger patch to clean up all the same cases without the bandaid approach.

On a side note, my patch should be changed so that it doesn't try to clean_builddir when things like "--pretend" and "--fetchonly" are in emerge's myopts.

Zac
-- 
gentoo-portage-dev@g.o mailing list