Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Update in_iuse & get_libdir inherit check for EAPI 6
Date: Mon, 16 Nov 2015 17:56:13
Message-Id: 564A18B0.3000709@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] repoman: Update in_iuse & get_libdir inherit check for EAPI 6 by "Michał Górny"
1 On 11/16/2015 08:58 AM, Michał Górny wrote:
2 > Update the eclass inherit check not to complain about in_iuse and
3 > get_libdir in EAPI 6 since they no longer require the respective
4 > eclasses.
5 > ---
6 > pym/repoman/checks/ebuilds/checks.py | 7 ++++++-
7 > 1 file changed, 6 insertions(+), 1 deletion(-)
8 >
9 > diff --git a/pym/repoman/checks/ebuilds/checks.py b/pym/repoman/checks/ebuilds/checks.py
10 > index a00d518..e23fcfe 100644
11 > --- a/pym/repoman/checks/ebuilds/checks.py
12 > +++ b/pym/repoman/checks/ebuilds/checks.py
13 > @@ -524,8 +524,13 @@ class InheritEclass(LineCheck):
14 > yield 'no function called from %s.eclass; please drop' % self._eclass
15 >
16 > _usex_supported_eapis = ("0", "1", "2", "3", "4", "4-python", "4-slot-abi")
17 > +_in_iuse_supported_eapis = ("0", "1", "2", "3", "4", "4-python", "4-slot-abi",
18 > + "5", "5-hdepend", "5-progress")
19 > +_get_libdir_supported_eapis = _in_iuse_supported_eapis
20 > _eclass_eapi_functions = {
21 > - "usex": lambda eapi: eapi not in _usex_supported_eapis
22 > + "usex": lambda eapi: eapi not in _usex_supported_eapis,
23 > + "in_iuse": lambda eapi: eapi not in _in_iuse_supported_eapis,
24 > + "get_libdir": lambda eapi: eapi not in _get_libdir_supported_eapis,
25 > }
26 >
27 > # eclasses that export ${ECLASS}_src_(compile|configure|install)
28 >
29
30 Looks good.
31 --
32 Thanks,
33 Zac