| 1 |
On 01/13/2012 11:52 AM, Mike Frysinger wrote: |
| 2 |
> The writable issue shows up when using `ebuild` as non-root users |
| 3 |
> in non-prefix setups. So always do it. |
| 4 |
> |
| 5 |
> Signed-off-by: Mike Frysinger <vapier@g.o> |
| 6 |
> --- |
| 7 |
> bin/ebuild-helpers/prepstrip | 2 +- |
| 8 |
> 1 files changed, 1 insertions(+), 1 deletions(-) |
| 9 |
> |
| 10 |
> diff --git a/bin/ebuild-helpers/prepstrip b/bin/ebuild-helpers/prepstrip |
| 11 |
> index 1d7b3d2..ee547f2 100755 |
| 12 |
> --- a/bin/ebuild-helpers/prepstrip |
| 13 |
> +++ b/bin/ebuild-helpers/prepstrip |
| 14 |
> @@ -224,7 +224,7 @@ do |
| 15 |
> # unwritable objects. Make them temporarily writable for the |
| 16 |
> # stripping. |
| 17 |
> was_not_writable=false |
| 18 |
> - if [[ -n ${EPREFIX} && ! -w ${x} ]] ; then |
| 19 |
> + if [[ ! -w ${x} ]] ; then |
| 20 |
> was_not_writable=true |
| 21 |
> chmod u+w "${x}" |
| 22 |
> fi |
| 23 |
|
| 24 |
LGTM |
| 25 |
-- |
| 26 |
Thanks, |
| 27 |
Zac |
Archives