| 1 |
-----BEGIN PGP SIGNED MESSAGE-----
|
| 2 |
Hash: SHA512
|
| 3 |
|
| 4 |
On Wed, 13 Aug 2014 23:09:50 +0200
|
| 5 |
Alexander Berntsen <bernalex@g.o> wrote:
|
| 6 |
|
| 7 |
> |
| 8 |
> For 3, I think it looks nice but you should check with Brian & Tom |
| 9 |
> about whether to put it in now or in the refactor branch. Also, please |
| 10 |
> ask QA about it so we don't get another bikeshed marathon to deal |
| 11 |
> with. |
| 12 |
> |
| 13 |
> Thanks for doing this! |
| 14 |
> - -- |
| 15 |
> Alexander |
| 16 |
> bernalex@g.o |
| 17 |
|
| 18 |
I've already reviewed this patch in the original thread. I also had
|
| 19 |
him re-do it into a separate function so it would be easy to insert
|
| 20 |
into the current master without disrupting the rewrite. The rewrite
|
| 21 |
should be easily rebased including this patch plus the few others
|
| 22 |
recently applied.
|
| 23 |
|
| 24 |
But yes, having QA's approval is needed...
|
| 25 |
|
| 26 |
I know it is already scheduled with them. :)
|
| 27 |
|
| 28 |
- --
|
| 29 |
Brian Dolbec <dolsen>
|
| 30 |
|
| 31 |
-----BEGIN PGP SIGNATURE-----
|
| 32 |
Version: GnuPG v2.0.22 (GNU/Linux)
|
| 33 |
|
| 34 |
iQF8BAEBCgBmBQJT7F4TXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
|
| 35 |
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy
|
| 36 |
MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfL82oIANWK+BzWLXVg6A7+sXWAlVWH
|
| 37 |
J+WHtubENpq/Cl25H/MSF7altoZ4ZpZVJ15E1ZvGIV47g3A8mZJQEmwSvQ6ZYdll
|
| 38 |
YotyIGQTsETgyAUe4THngsOx8+mP1MP8mHYl8nHAz6Tu5+OJQxgrdHai3JAsKH/X
|
| 39 |
KhGOHhhIBsThP9ooj2WoLjijwZ0epgmyN3T6SDy3GxOs18ugdXQuR3EGi5Wa2JCo
|
| 40 |
57xHdfZIvPFL2tBiLQuDwiN62Ygb5RfyNfiqYTy9zypK1tnNihUWIF8QYZ3NgFVc
|
| 41 |
pYWYXLVTbvd8/SDAUTcOy+Z5a9hVBZzudXJbi4YVRpSkRHV4YZx1AkojwbKyye0=
|
| 42 |
=H614
|
| 43 |
-----END PGP SIGNATURE----- |
Archives