Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: Brian Dolbec <dolsen@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Fix off-by-one error in supported EAPI list
Date: Sun, 17 Aug 2014 18:57:48
Message-Id: 20140817205827.18b77dda@pomiot.lan
In Reply to: Re: [gentoo-portage-dev] [PATCH] Fix off-by-one error in supported EAPI list by Brian Dolbec
1 Dnia 2014-08-17, o godz. 11:44:55
2 Brian Dolbec <dolsen@g.o> napisał(a):
3
4 > Hmm, I thought EAPI was suppose to be a string...
5 >
6 > from portage/const.py:
7 >
8 > EAPI = 5
9 >
10 > which is clearly an integer.
11
12 It generally is. However, the Council-defined EAPIs match integers
13 so far and portage seems to be taking advantage of that.
14
15 > Shouldn't it be a list of supported EAPI's if it is a string?
16
17 From a quick grep, this constant is used twice:
18
19 1. to generate the _supported_eapis list using range(),
20
21 2. to output newest supported EAPI when EAPI masking occurs.
22
23 We could supposedly replace that with list of officially supported
24 EAPIs but I don't have any strong opinion on this...
25
26 --
27 Best regards,
28 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature