| 1 |
On 7/2/20 8:50 AM, Wynn Wolf Arbor wrote: |
| 2 |
> Hi, |
| 3 |
> |
| 4 |
> Whilst configuring a bunch of overlay repositories via repos.conf, I |
| 5 |
> discovered that not all boolean options take the same values. Some only |
| 6 |
> take 'true' and 'false', others are documented only as 'yes' or 'no', |
| 7 |
> but take 'true', 'false', 'yes', and 'no'. This is inconsistent and can |
| 8 |
> lead to very confusing outcomes, so I decided to write a patch. |
| 9 |
> |
| 10 |
> I came across https://bugs.gentoo.org/703698 whilst working on this, and |
| 11 |
> since my work was tangentially related, decided to fix that as well. |
| 12 |
> |
| 13 |
> Wynn Wolf Arbor (2): |
| 14 |
> repos.conf: Use consistent list of values for boolean options |
| 15 |
> git: Verify boolean values passed to sync-git-verify-commit-signature |
| 16 |
> |
| 17 |
> lib/portage/repository/config.py | 4 +-- |
| 18 |
> lib/portage/sync/modules/git/__init__.py | 11 ++++++++ |
| 19 |
> lib/portage/sync/modules/git/git.py | 2 +- |
| 20 |
> lib/portage/sync/modules/rsync/rsync.py | 2 +- |
| 21 |
> man/portage.5 | 45 +++++++++++++++----------------- |
| 22 |
> 5 files changed, 36 insertions(+), 28 deletions(-) |
| 23 |
|
| 24 |
|
| 25 |
Thanks! I've merged both patches, with a couple of additional lower() |
| 26 |
calls for case insensitivity: |
| 27 |
|
| 28 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=141ef203661248a2c29945f8c6770ce0c242eaf0 |
| 29 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=33b08baff4825bf84f639cf213de92ed36f76771 |
| 30 |
-- |
| 31 |
Thanks, |
| 32 |
Zac |
Archives