Gentoo Archives: gentoo-portage-dev

From: Ed Catmur <ed@×××××××××.uk>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Default Phase Hooks
Date: Fri, 09 Feb 2007 10:37:43
Message-Id: 1171017374.26769.7.camel@capella.catmur.co.uk
In Reply to: [gentoo-portage-dev] Default Phase Hooks by Alec Warner
1 On Fri, 2007-02-09 at 06:51 +0000, Alec Warner wrote:
2 > In order to facilitate better ease of use with phase hooks, I propose a
3 > paludis-style default phase hook. Basically ebuild.sh provides a default
4 > hook that looks in PORTAGE_HOOKS_DIR/{pre,post}_${EBUILD_PHASE}/ for shell
5 > scripts and sources them.
6 What is PORTAGE_HOOKS_DIR? Where is it set?
7
8 > ...
9 > Comments and Questions are welcome.
10 The quoting doesn't seem quite right. Assuming you intend to expand the
11 glob at define time, it should be
12 + eval "${prefix}_${EBUILD_PHASE}() {
13 + for script in \"${PORTAGE_HOOKS_DIR}/${prefix}_${EBUILD_PHASE}/\"*.sh
14 + do
15 + ebegin \"Sourcing \$script\"
16 + qa_source \$script || die \"Failed to source \$script\"
17 + eend
18 + done
19 + }"
20
21 Ed
22
23 --
24 gentoo-portage-dev@g.o mailing list