Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test()
Date: Sun, 17 Aug 2014 13:02:21
Message-Id: 53F0A7D5.9070609@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test() by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 17/08/14 00:22, Michał Górny wrote:
5 > Before, the status message indicating src_test() run was output
6 > only if the default EAPI implementation was used. If an ebuild
7 > overrode test phase, the test phase output lacked delimitation.
8 > Instead, output uniform status messages before and after running
9 > src_test() alike for other phase functions.
10 Does this actually fix anything or matter to anyone? It looks fine to
11 me, but seeing as there's no bug, I'm not sure it's actually fixing
12 anything.
13
14 Also, for the commit message, remember what we talked about with
15 active sentences. Write "Do Foo to solve Bar", rather than "Bar is a
16 problem. Here is a lengthy paragraph about that with a fix, Foo,
17 somewhere at the end -- hope you don't miss it!".
18 - --
19 Alexander
20 bernalex@g.o
21 https://secure.plaimi.net/~alexander
22 -----BEGIN PGP SIGNATURE-----
23 Version: GnuPG v2
24 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
25
26 iF4EAREIAAYFAlPwp9UACgkQRtClrXBQc7XT0QEAjSQuUGkU84YKxtkIC4b/qSIN
27 Iek0NB1dN1QV9eV52bQA/3SSgT/WJPjqAt9kz1xa+mrDENaGcYLsKLpHdOhjqhTb
28 =5r99
29 -----END PGP SIGNATURE-----