1 |
Am 15.01.2014 19:41, schrieb Tom Wijsman: |
2 |
>>> Yes, I see some commit messages not refer to bugs which is |
3 |
>>> something we will want to avoid; think this might need to go |
4 |
>>> into the commit policy. |
5 |
>>> |
6 |
>> There's nothing wrong with fixing/implementing something that |
7 |
>> nobody filed a bug about. |
8 |
> |
9 |
> Sorry, consider the common case where a bug was filed but the |
10 |
> commit message does not refer to that bug. Also note that I am |
11 |
> trying to refer to the ChangeLog of Portage itself, not that of the |
12 |
> ebuild; thus I mean the commit messages for the Portage repo, not |
13 |
> to the Portage tree. |
14 |
> |
15 |
Not sure if we're talking about the same things. |
16 |
|
17 |
1) If you fix something that has a bug, you should refer to that in |
18 |
the git commit message. |
19 |
2) There's nothing wrong with a git commit message that does not refer |
20 |
to a bug, if there is no bug filed. |
21 |
|
22 |
> The whole point of documenting it in a workflow is to make it |
23 |
> converge; |
24 |
|
25 |
Not the "converge" I meant. |
26 |
|
27 |
What I meant was to allow people to test different styles and hope |
28 |
that the one that works best will be adopted by everyone at some |
29 |
point. Once that happens you can document that style. |
30 |
|
31 |
> if you instead leave things unclear or undocumented, you have no |
32 |
> guaranteed convergence and might even see a disconvergence. |
33 |
|
34 |
Yes, maybe. One then needs to see if that is a problem and if it is |
35 |
then force everyone to use one style. |
36 |
|
37 |
> |
38 |
> It's already making people unhappy right now; because as it is |
39 |
> documented now, it is turned from the meaningful experience that |
40 |
> the previous Portage team had before to something that is |
41 |
> meaningless. It is a regression in checking the list of bugs that |
42 |
> block the tracker, as the states of the bugs no longer have a value |
43 |
> as it is documented now. |
44 |
> |
45 |
Previously the bug state was not used at all. There is no regression. |