Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH] repoman: revert preserve_old_lib deprecation (bug 480244)
Date: Tue, 23 Feb 2021 23:41:42
Message-Id: 20210223234119.646004-1-zmedico@gentoo.org
1 Repoman should not report that preserve_old_lib is deprecated,
2 since preserve-libs is not covered by PMS.
3 This reverts commit 49cbc17bf7b99be586e158c1bd588cfe91dfe58c.
4
5 Bug: https://bugs.gentoo.org/480244
6 Bug: https://bugs.gentoo.org/692486
7 Signed-off-by: Zac Medico <zmedico@g.o>
8 ---
9 repoman/cnf/linechecks/linechecks.yaml | 2 +-
10 .../lib/repoman/modules/linechecks/deprecated/deprecated.py | 4 ++--
11 2 files changed, 3 insertions(+), 3 deletions(-)
12
13 diff --git a/repoman/cnf/linechecks/linechecks.yaml b/repoman/cnf/linechecks/linechecks.yaml
14 index 2182b467a..7c040e2b2 100644
15 --- a/repoman/cnf/linechecks/linechecks.yaml
16 +++ b/repoman/cnf/linechecks/linechecks.yaml
17 @@ -25,7 +25,7 @@ errors:
18 DEPRECATED_BINDNOW_FLAGS: 'Deprecated bindnow-flags call'
19 EAPI_DEFINED_AFTER_INHERIT: 'EAPI defined after inherit'
20 NO_AS_NEEDED: 'Upstream asneeded linking bug (no-as-needed)'
21 - PRESERVE_OLD_LIB: 'Ebuild calls deprecated preserve_old_lib'
22 + PRESERVE_OLD_LIB: 'Upstream ABI change workaround on line: %d'
23 BUILT_WITH_USE: 'built_with_use'
24 NO_OFFSET_WITH_HELPERS: 'Helper function is used with D, ROOT, ED, EROOT or EPREFIX'
25 USEQ_ERROR: 'Ebuild calls deprecated useq function'
26 diff --git a/repoman/lib/repoman/modules/linechecks/deprecated/deprecated.py b/repoman/lib/repoman/modules/linechecks/deprecated/deprecated.py
27 index d1a590f1d..ad488c53a 100644
28 --- a/repoman/lib/repoman/modules/linechecks/deprecated/deprecated.py
29 +++ b/repoman/lib/repoman/modules/linechecks/deprecated/deprecated.py
30 @@ -19,8 +19,8 @@ class DeprecatedHasq(LineCheck):
31
32
33 class PreserveOldLib(LineCheck):
34 - """Check for calls to the deprecated preserve_old_lib function."""
35 - repoman_check_name = 'ebuild.minorsyn'
36 + """Check for calls to the preserve_old_lib function."""
37 + repoman_check_name = 'upstream.workaround'
38 re = re.compile(r'.*preserve_old_lib')
39 error = 'PRESERVE_OLD_LIB'
40
41 --
42 2.26.2

Replies