| 1 |
On 3/11/20 9:36 PM, Matt Turner wrote: |
| 2 |
> On Wed, Mar 11, 2020 at 9:31 PM Zac Medico <zmedico@g.o> wrote: |
| 3 |
>>> @@ -562,7 +575,16 @@ def findPackages( |
| 4 |
>>> |
| 5 |
>>> # Exclude if binpkg exists in the porttree and not --deep |
| 6 |
>>> if not destructive and port_dbapi.cpv_exists(cpv): |
| 7 |
>>> - continue |
| 8 |
>>> + if not options['changed-deps']: |
| 9 |
>>> + continue |
| 10 |
>> |
| 11 |
>> We can't can't continue above, since that will skip all of the filters |
| 12 |
>> that occur later in the loop. So, we have to nest the below changed-deps |
| 13 |
>> code under if options['changed-deps']: |
| 14 |
> |
| 15 |
> I'm happy to make that change, but I don't think it's necessary, |
| 16 |
> strictly speaking, since this is inside an 'if not destructive' |
| 17 |
> conditional and the only filter afterwards is 'if destructive'. |
| 18 |
> |
| 19 |
> In case we add more filters in the future, I'll make the change you suggested. |
| 20 |
|
| 21 |
Yeah, I think it significantly reduces the cognitive burden to the |
| 22 |
reader as well. Thanks! |
| 23 |
|
| 24 |
> Thanks a bunch for your reviews! |
| 25 |
|
| 26 |
You're welcome! |
| 27 |
-- |
| 28 |
Thanks, |
| 29 |
Zac |
Archives