Gentoo Archives: gentoo-portage-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Michael Orlitzky <mjo@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH v2] eapply: Output verbosely only if patch fails to apply with -F0
Date: Fri, 13 Dec 2019 13:55:55
Message-Id: CAJ0EP42D-4gYt+JOskY+vaZ5JCwZ7_1KNETKG218asxDKBxnMg@mail.gmail.com
In Reply to: Re: [gentoo-portage-dev] [PATCH v2] eapply: Output verbosely only if patch fails to apply with -F0 by Ulrich Mueller
1 On Thu, Dec 12, 2019 at 4:15 PM Ulrich Mueller <ulm@g.o> wrote:
2 >
3 > >>>>> On Thu, 12 Dec 2019, Mike Gilbert wrote:
4 >
5 > > On Wed, Nov 27, 2019 at 11:14 PM Michał Górny <mgorny@g.o> wrote:
6 > >> On Wed, 2019-11-27 at 23:49 +0100, Ulrich Mueller wrote:
7 >
8 > >> > The difference is that there is now a QA warning for something that
9 > >> > is perfectly within the spec. Maybe the extra verboseness would be
10 > >> > enough, but the eqawarn line should be omitted? It doesn't provide
11 > >> > any info that isn't already present in the output of patch itself.
12 > >>
13 > >> It helps people understand why some patches throw a wall of text
14 > >> while others don't.
15 >
16 > > It also triggers pointless bug reports. Please remove this.
17 >
18 > I don't like that eqawarn either (see above).
19 >
20 > OTOH, users shouldn't normally have "qa" in PORTAGE_ELOG_CLASSES,
21 > so they won't see the warning?
22
23 Here's a bug report filed by a user, which is what prompted me to
24 reply on this thread in the first place.
25
26 https://bugs.gentoo.org/702608

Replies