Gentoo Archives: gentoo-portage-dev

From: R0b0t1 <r030t1@×××××.com>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Fix Misc. Bash Errors in phase-helpers.sh.
Date: Sun, 04 Feb 2018 07:55:05
Message-Id: CAAD4mYgA4BVMR0a1wiNO8LTa2+AfmCBzyFANuVfJMEEADE5tZQ@mail.gmail.com
1 On line 699, I suspect the test may erroneously expand into:
2
3 if [ -f ./Makefile ./makefile -o -f ./GNUmakefile ] ; then
4
5 If both files are present. The test was changed to include both names
6 explicitly. It could also be rewritten with [[, but it seems like it
7 would still either need a loop or multiple tests.
8
9
10 The other changes are almost stylistic. I made a PR
11 (https://github.com/gentoo/portage/pull/251) before I remembered that
12 that repo was a mirror.
13
14 Cheers,
15 R0b0t1

Attachments

File name MIME type
0001-Fix-misc.-bash-errors.patch text/x-patch