Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Fix versioning system
Date: Tue, 06 Dec 2016 03:59:16
Message-Id: 20161205195912.6a94c333.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] repoman: Fix versioning system by Zac Medico
1 On Mon, 5 Dec 2016 13:10:38 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 12/05/2016 12:32 PM, Brian Dolbec wrote:
5 > > On Mon, 5 Dec 2016 11:42:10 -0800
6 > > Brian Dolbec <dolsen@g.o> wrote:
7 > >
8 > >> From 1586f1a25c41fb6036a24b47cfa58e3e818b8a58 Mon Sep 17 00:00:00
9 > >> 2001 From: Brian Dolbec <dolsen@g.o>
10 > >> Date: Mon, 5 Dec 2016 11:27:15 -0800
11 > >> Subject: [PATCH] repoman: Fix versioning system
12 > >>
13 > >> Repoman had been showing the portage version. Which was the same
14 > >> for the last release. Copy the live versions code from portage,
15 > >> Modify as needed to get the correct tag info. Add portage version
16 > >> to --version output. ---
17 > >> repoman/pym/repoman/__init__.py | 70
18 > >> +++++++++++++++++++++++++++++++++++++++++
19 > >
20 > > For some reason, without the single quoting the match string, "git
21 > > describe --match portage-*" would fail while "git describe --match
22 > > repoman-*" would without the single quotes.
23 > >
24 > > Anyway, I updated the repoman patch to single quote it.
25 >
26 > Yeah, it definitely needs to be quoted, in order to prevent shell
27 > expansion. Apparently you had a file or directory patching portage-*
28 > in your working directory.
29
30
31 merged
32 --
33 Brian Dolbec <dolsen>