Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] Colorize packages in world_sets (bug 583164)
Date: Wed, 25 May 2016 07:15:39
Message-Id: 57455110.1060700@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 2/2] Colorize packages in world_sets (bug 583164) by Adam Mills
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 You give no justification for the first commit. This commit message
5 has some grammar issues, so I don't know what you are trying to say in
6 it.
7
8 The bug has same relevant discussion. If you could give some reason
9 for reverting in patch 1, and clean up the message of patch 2, the
10 patches look good to me otherwise (although I'll have to test them of
11 course).
12
13 Note that you don't need a '\' inside parentheses in Python for patch 2.
14 - --
15 Alexander
16 bernalex@g.o
17 https://secure.plaimi.net/~alexander
18 -----BEGIN PGP SIGNATURE-----
19 Version: GnuPG v2
20
21 iQIcBAEBCgAGBQJXRVEPAAoJENQqWdRUGk8BoPcP/3oBJqX2fqMCsol8wogVwiig
22 vKaE313fZeirLINE4D2s+6Jvks0UXiuR31aWkuuHdIzH0/hYVztMENJvIS2eZWc1
23 Mtv1fzljPdA9JZtBrJTwxrEyr7shV0xCamVQ8oU9lVTVUxUbNmJJwLIaiog2mGjL
24 QBcMjYNOY6lXUMpXAipfDC9rtXEDNF/xwyZXKIoxVlwFicH1Xm+tIS0YsqHtOUW1
25 nvxDL5Js+2cmG2hxbdITva3QlSpptg5Sv+k9U8gP7gVKJaFUIJMEQr1ydTp4oSSt
26 l0pqm38HrMpo2KMHySKQwVCFHW6IbBZ5nwc2ziVj+dDmKsLKWOaGMnmf4mzgBp67
27 6UuNJXN+NBpG2DW57Gvf0OSQvffHWNblYME+IcVnw+eqc27Rv3qU4Fk3LVvf4/Rl
28 WvjmigwfJOX07fQFaSHR9/nU5jVldv5wuE3AmQInZHKcE9sABCY/B96Cbk6dqkCr
29 umJC7J7egw2hAIk/252+OLfgoJxVRcHn0z+CbZpwLFKapevJwEpZB2oDHLhLQ+Dx
30 u5UOXfEEg8xppYjvwuxIn6tVjH9FL02rJZwdaitbNgx3tz6/Yn6GzsRdGj64izra
31 +nFwiujrX3MQWLaJUuQRaKZw4ltdYBz915rbXuuqFDObtloVHCKu/zVunXQc07cL
32 /pT43QOB0qVQtuvHCPnc
33 =bjDF
34 -----END PGP SIGNATURE-----