[gentoo-portage-dev] [PATCH] Allow non-default make.conf to set ROOT

[Daniel Barkalow]

If PORTAGE_CONFIGROOT is not "/", this is likely to mean that we're not 
intended to be working on the live system (and, in fact, are probably 
making stuff that's incompatible with the live system). The user probably 
wants to use ROOT, but we ought to let the make.conf in the 
PORTAGE_CONFIGROOT set ROOT, so there's only one variable that the user 
needs to keep straight.

I could do a bit more extensive version to check the config file's ROOT 
(if present) for being a directory, like the environment variable is 
checked, and to make the environment variable override the config file, if 
either of those is worthwhile.

Signed-off-by: Daniel Barkalow <barkalow@××××××××.org>

Index: pym/portage.py
===================================================================
--- pym/portage.py	(revision 5054)
+++ pym/portage.py	(working copy)
@@ -1128,6 +1128,8 @@
 					noiselevel=-1)
 				sys.exit(1)
 
+			if config_root != "/" and "ROOT" in self.mygcfg:
+				target_root = self.mygcfg["ROOT"]
 
 			self.configlist.append(self.mygcfg)
 			self.configdict["conf"]=self.configlist[-1]
-- 
gentoo-portage-dev@g.o mailing list