Re: [gentoo-portage-dev] [PATCH v3] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491.

[Sebastian Luther]

Am 15.01.2014 22:03, schrieb Chris Reffett:
> +	def check_eapi(self, eapi):
> +		return eapi in ('0', '1')
> +

Instead of hard coding EAPIs here, you should use the functions in
portage.eapi like eapi_has_src_prepare_and_src_configure().

Same applies for the later part of the patch.

The class names of the checks have the same issue. I understand that
there are existing checks with such names, but that doesn't mean that's
a good idea to keep using them.
You could name them after the phases you're checking for.

Sebastian