1 |
On Saturday 18 January 2014 17:57:38 Tom Wijsman wrote: |
2 |
> On Sat, 18 Jan 2014 08:43:12 -0800 "W. Trevor King" wrote: |
3 |
> > On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote: |
4 |
> > I think the idea is that you shouldn't need to refer to an external |
5 |
> > resource like the mailing list to understand the idea behind the |
6 |
> > patch, |
7 |
> |
8 |
> Either someone cares about the background of a patch or he/she doesn't. |
9 |
|
10 |
full details to understand the change must be in the commit message. saying |
11 |
"go find it in the mailing list" is not a workable solution. |
12 |
|
13 |
this doesn't mean you have to copy & paste the entire discussion, but it does |
14 |
mean you have to distill things down. for topics that go on for a while, |
15 |
adding a tag linking to the mailing list archive is certainly OK. |
16 |
|
17 |
when it comes to tags, i only copy in what other people have bothered posting. |
18 |
so if someone posts their Reviewed-by or Acked-by, i'll use them. |
19 |
-mike |