Re: [gentoo-portage-dev] [PATCH] post_sync actions

[Ned Ludd]

On Sat, 2005-10-29 at 20:32 -0400, Ned Ludd wrote:
> On Sun, 2005-10-30 at 03:15 +0900, Jason Stubbs wrote:
> > On Sunday 30 October 2005 01:03, Ned Ludd wrote:
> > > The following simple patch adds the ability for to run a userside
> > > post_sync script, right now it's only used with rsync but the idea could
> > > be adopted rather easy for other methods of transfer that portage may
> > > use. The basic idea is to be able to preform a set of maintenance tasks
> > > right after sync up with an rsync server. Be that adding a call to svn
> > > co, cvs co, ebuild manipulation, updating search caches or other. I've
> > > been using this method on and off sense about portage-2.0.51.16 without
> > > any problems. Any comments before I file a bug for inclusion?
> >
> > This really goes hand in hand with the pre/post phase hooks patch. That patch,
> > however, implements hooks as bash functions rather than external executables.
> > The discrepancy there should probably be worked out before either are
> > included. Personally, I'm for the external executable method but I'm sure
> > that there will be alternative opinions...
>
> The pre/post hooks the way it's being worked out seems pretty ideal for
> it's purpose. Where this post_sync hook is an action hook vs a phased
> hook and we cant really source any files in. I'm thinking both ways are
> fitting for what they should do.
>
> One thing ferringb pointed out that is almost any call portage from the
> post_sync might make you spend a little extra time doing a regen.
> I don't see an ideal way to work around in the code and I'm thinking it
> might even be better in the case of dynamic ebuild manipulation done via
> the post_sync. However if you wanted to say have a call a
> /usr/bin/glsa-check -nl 2>/dev/null | /bin/sed -ne '/^[^[:space:]]\
> +[[:space:]]\[N\]/p'glsa-check -l
> then we waste some extra time.
>
> He had also mentioned perhaps making the post sync a user definable
> variable and then spwaning as POST_SYNC="exec1:exec2:exec3". He pointed
> out that it would also open a hole in portage where it would look in
> profile dirs.

updated patch that adds error checking and shifts when we exexve to the
end patch

-- 
Ned Ludd <solar@g.o>
Gentoo Linux