| 1 |
On Mon, Oct 03, 2011 at 02:48:55AM -0700, Zac Medico wrote: |
| 2 |
> On 10/02/2011 05:21 PM, Zac Medico wrote: |
| 3 |
> > On 10/02/2011 04:22 PM, Brian Harring wrote: |
| 4 |
> >> On Sun, Oct 02, 2011 at 02:10:09PM -0700, Zac Medico wrote: |
| 5 |
> > I've implemented it with booleans in this commit: |
| 6 |
> > |
| 7 |
> > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=c8cd3a985cc529299411d7343a11004b7d1330ef |
| 8 |
> > |
| 9 |
> >> Should use a space delimited list instead named hashes instead; those |
| 10 |
> >> being the hashes that should be generated, and that can be /used/. |
| 11 |
> >> Not in the list, not an acceptable hash (even if a manifest2 carries |
| 12 |
> >> that data). |
| 13 |
> > |
| 14 |
> > Why? Boolean flags are simpler and they work. |
| 15 |
> |
| 16 |
> After some thought, I like the space delimited approach better. Here's |
| 17 |
> the patch, which retains the ability to remove the manifest hash |
| 18 |
> settings from layout.conf after they become redundant: |
| 19 |
> |
| 20 |
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d9d0606fe01618cc81fb0b862ada91149dad3746 |
| 21 |
|
| 22 |
Suggest you go through the implementation a bit closer; quick look, if |
| 23 |
the repo no longer uses what portage considers a required hash (atm, |
| 24 |
sha1), it still will force it in; while that's rather annoying for |
| 25 |
manifest creation, the validation logic there strikes me as probably |
| 26 |
being buggy for that case. |
| 27 |
|
| 28 |
~harring |
Archives