Gentoo Archives: gentoo-portage-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-portage-dev@l.g.o
Cc: SebastianLuther@×××.de
Subject: Re: [gentoo-portage-dev] [PATCH] egencache: --write-timestamp to create metadata/timestamp.chk
Date: Fri, 29 Nov 2013 14:17:17
Message-Id: 201311290917.12195.vapier@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] egencache: --write-timestamp to create metadata/timestamp.chk by SebastianLuther@gmx.de
1 On Friday 29 November 2013 08:36:43 SebastianLuther@×××.de wrote:
2 > + f.write(time.strftime("%a, %d %b %Y %H:%M:%S +0000\n",
3
4 would be nice to pull that time format out and into the const module. the
5 emerge actions.py file uses it too (twice actually).
6
7 > + except IOError:
8 > + ret.append(1)
9
10 ret.append(os.EX_IOERR) ?
11
12 otherwise looks good now
13 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature