| 1 |
On 05/07/2016 04:38 AM, Alexander Berntsen wrote: |
| 2 |
> Still barely readable without putting it in git and getting colours. |
| 3 |
> Which tells me this should probably not look the way it looks at |
| 4 |
> present... |
| 5 |
|
| 6 |
Yeah, we could certainly split the code out into standalone shell |
| 7 |
scripts and install them in sub-directory of $PORTAGE_BIN_PATH. |
| 8 |
|
| 9 |
The code makes a good test case for make.* parsing with respect to |
| 10 |
quoting and multiple layers of escapes, so maybe we should keep |
| 11 |
something similar in the unit tests. |
| 12 |
|
| 13 |
The code was sort of a quick and dirty fix that was never really |
| 14 |
intended to be readable, which may have contributed to the 2+ years that |
| 15 |
went by before someone got around to writing a patch. |
| 16 |
|
| 17 |
> But it looks like it's doing what it's supposed to be doing. So go |
| 18 |
> ahead and push. |
| 19 |
> |
| 20 |
> I think the message title is about a billion characters above budget, |
| 21 |
> so perhaps just make it "make.globals: Respect ssh_config port (bug |
| 22 |
> 499198)" or something; your call though. |
| 23 |
|
| 24 |
Thanks, I've pushed it with your shorter commit message. |
| 25 |
-- |
| 26 |
Thanks, |
| 27 |
Zac |
Archives