Gentoo Archives: gentoo-portage-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] world-writable: tune for Prefix
Date: Mon, 25 Jul 2022 16:41:24
Message-Id: Yt7Hrg/dca+mOu1L@gentoo.org
1 bin/install-qa-check.d/90world-writable: include EPREFIX in reports
2
3 It is much less confusing and consistent to report full paths including
4 the leading EPREFIX.
5
6 Signed-off-by: Fabian Groffen <grobian@g.o>
7
8 diff --git a/bin/install-qa-check.d/90world-writable b/bin/install-qa-check.d/90world-writable
9 index 820683bd6..90b961a86 100644
10 --- a/bin/install-qa-check.d/90world-writable
11 +++ b/bin/install-qa-check.d/90world-writable
12 @@ -2,7 +2,7 @@
13
14 world_writable_check() {
15 # Now we look for all world writable files.
16 - local unsafe_files=$(find "${ED}" -type f -perm -2 | sed -e "s:^${ED}:/:")
17 + local unsafe_files=$(find "${ED}" -type f -perm -2 | sed -e "s:^${D}:/:")
18 local OLDIFS x prev_shopts=$-
19
20 OLDIFS=$IFS
21 @@ -19,7 +21,7 @@ world_writable_check() {
22 eqawarn
23 fi
24
25 - local unsafe_files=$(find "${ED}" -type f '(' -perm -2002 -o -perm -4002 ')' | sed -e "s:^${ED}:/:")
26 + local unsafe_files=$(find "${ED}" -type f '(' -perm -2002 -o -perm -4002 ')' | sed -e "s:^${D}:/:")
27 if [[ -n ${unsafe_files} ]] ; then
28 eqawarn "QA Notice: Unsafe files detected (set*id and world writable)"
29
30
31 --
32 Fabian Groffen
33 Gentoo on a different level

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-portage-dev] [PATCH] world-writable: tune for Prefix Mike Gilbert <floppym@g.o>