Gentoo Archives: gentoo-project

From: Joonas Niilola <juippis@×××××.com>
To: gentoo-project@l.g.o
Subject: Re: [gentoo-project] [RFC] GURU v2, now with reviewed layer
Date: Mon, 04 Feb 2019 18:14:56
In Reply to: [gentoo-project] [RFC] GURU v2, now with reviewed layer by "Michał Górny"
On 2/4/19 7:38 PM, Michał Górny wrote:
> Reviews can be done by devs or privileges users. Review by dev gives 3 > rep points, and by privileged user gives 1 rep point. Therefore, > a commit is merged if it's either reviewed by dev or 3 privileged users.
This could be 'exploited' with a group of friends. By exploited I mean small inner circles forming, where people just approve their friends commits without looking at them. I think after 3 approvals it should be pushed to be on top of some(/all) dev's to-be-merged list. But then again, would this system be any faster than current proxy-maint workflow, where other proxied maintainers already review and approve PRs? What about ebuilds not many people have knowledge of? Say, java stuff? If no user wants to take a look, it will always require a review from a dev, and judging how that goes even with current Github PRs, will it _ever_ get approved here? What would motivate a developer to review these ebuilds, if there's still separate proxy-maint stuff to work on?
> > > Users gain reviewing privilege also via reputation points. If a commit > range including user's commit gets merged to master, user gets 1 rep > point (independently of number of commits in the range). When user gets > 5 rep points, he can start reviewing stuff.
So this requires people to make commits to this overlay before being able to review there? Some system should exist, where for example your commits to ::gentoo counts toward this. Otherwise this could encourage people to make meaningless commits just to satisfy the counter.
> Your updated thoughts? >
_If_ in this approach a dev is still needed for merging stuff in the end, couldn't this somehow be applied to how the current proxy-maint system works? Is there a chance these ebuilds could end up in ::gentoo? _Could_ there be some voting system for that (although I believe that kills the incentive of ever adding this overlay as a user)? Still gotta say, this should prove to be a nice learning ground, and maybe a good place to host popular not-in-tree packages. Or with semi-dead projects where users are still trying to contribute (like MATE). Although I believe everyone's motivation is to get them in ::gentoo in the end. And as asked by someone in the previous thread, what's the plan of cleaning the overlay every now and then? (How?) Who takes care of broken packages?