| 1 |
On Sun, Jun 03, 2012 at 01:38:32PM +0100, Ciaran McCreesh wrote: |
| 2 |
> On Sun, 03 Jun 2012 12:42:45 +0300 |
| 3 |
> Samuli Suominen <ssuominen@g.o> wrote: |
| 4 |
> > When all there is required is dropping some "$@" to the Portage code |
| 5 |
> > and be done with it, and have everything be in consistent format... |
| 6 |
> |
| 7 |
> The question is not about the code, but about the design. Your design |
| 8 |
> doesn't make sense: there's no direct correspondence between functions |
| 9 |
> and phases, so it's not obvious where arguments to "default" get sent. |
| 10 |
> |
| 11 |
> "default" is for the easy cases. If you're wanting to do something |
| 12 |
> different, don't use it. |
| 13 |
|
| 14 |
Also, default can be used as the starting point for a more complex |
| 15 |
install. For example, you can call default, then once that returns, |
| 16 |
modify the image by adding/removing/moving files, adding init scripts, |
| 17 |
etc. |
| 18 |
|
| 19 |
So I would also strongly disagree with a ban on calling default from the |
| 20 |
install phase. |
| 21 |
|
| 22 |
William |
Archives