Gentoo Archives: gentoo-project

From: Samuli Suominen <ssuominen@g.o>
To: gentoo-project@l.g.o
Subject: Re: [gentoo-project] Re: Call for agenda items -- Council meeting 2012-06-12
Date: Sun, 03 Jun 2012 12:03:10
In Reply to: Re: [gentoo-project] Re: Call for agenda items -- Council meeting 2012-06-12 by Ulrich Mueller
On 06/03/2012 12:24 PM, Ulrich Mueller wrote:
>>>>>> On Sun, 03 Jun 2012, Samuli Suominen wrote: >>>> this one is what I'm really after for: >>> >>>> default for src_install() in EAPI=5 should accept "$@" in correct place >>>> to avoid usage of EXTRA_EMAKE within ebuilds/eclasses and to avoid >>>> duplicating the Portage code for DOCS. >>>> NOTE: When this was last voted on for EAPI=3, we didn't have this DOCS >>>> handling, and this wasn't important yet. >>> >>>> emake DESTDIR="${D}" "$@" install >>> >>> Again, this could be called directly, which has the advantage that it >>> makes it obvious that src_install isn't the default. > >> The difference is working the tree when you have to alter ebuilds which >> have been written like: > >> DOCS=( AUTHORS README.NOW "${FILESDIR}"/README.Gentoo ) > >> src_install() { >> default > >> echo "Some command here." >> } > >> At this point you have to move content of DOCS which may or may not >> rely on the ""quoting with array"". Remove the call to default. And >> then duplicate the EAPI=4 default into the ebuild. > > Why would you have to copy the EAPI 4 src_install code? Apart from > emake, you only need the single line: > dodoc AUTHORS README.NOW "${FILESDIR}"/README.Gentoo > or > dodoc "${DOCS[@]}" > if you want to keep the variable. > > Ulrich >
More like 2 lines, first one being the s/default/emake DESTDIR="${D}" htmldir=/path/to/example install/ second one being the DOCS which might in an array or not, with or without quoting or * in place Then do this multiple times by month all over the tree :/ And I did mention it makes the default EAPI=4 src_install() useless for eclasses due to lack of support for the arguments too? When all there is required is dropping some "$@" to the Portage code and be done with it, and have everything be in consistent format... - Samuli


Subject Author
Re: [gentoo-project] Re: Call for agenda items -- Council meeting 2012-06-12 Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>