Gentoo Archives: gentoo-proxy-maint

From: Joonas Niilola <juippis@g.o>
To: gentoo-proxy-maint@l.g.o
Subject: Re: [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests
Date: Sat, 04 Apr 2020 07:45:32
Message-Id: a9c0048c-6d44-6b4d-c02f-5b223436b201@gentoo.org
In Reply to: [gentoo-proxy-maint] [PATCH] games-arcade/oshu: Fix tests by "Haelwenn (lanodan) Monnier"
1 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b23467f58e057f864b964b41fe311f401517588
2
3 On 4/1/20 9:07 PM, Haelwenn (lanodan) Monnier wrote:
4 > Turn out it was failing because cmake.eclass calls ctest directly
5 >
6 > Signed-off-by: Haelwenn (lanodan) Monnier <contact@×××××××××.me>
7 > ---
8 > games-arcade/oshu/oshu-2.0.1.ebuild | 8 ++++----
9 > games-arcade/oshu/oshu-9999.ebuild | 8 ++++----
10 > 2 files changed, 8 insertions(+), 8 deletions(-)
11 >
12 > diff --git a/games-arcade/oshu/oshu-2.0.1.ebuild b/games-arcade/oshu/oshu-2.0.1.ebuild
13 > index 84d415b3c11..f394d808178 100644
14 > --- a/games-arcade/oshu/oshu-2.0.1.ebuild
15 > +++ b/games-arcade/oshu/oshu-2.0.1.ebuild
16 > @@ -32,10 +32,6 @@ RDEPEND="
17 >
18 > DEPEND="${RDEPEND}"
19 >
20 > -# Doesn't build executable needed for the test
21 > -# https://github.com/fmang/oshu/issues/87
22 > -RESTRICT="test"
23 > -
24 > src_prepare() {
25 > if use osu-skin; then
26 > eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
27 > @@ -53,3 +49,7 @@ src_configure() {
28 >
29 > cmake_src_configure
30 > }
31 > +
32 > +src_test() {
33 > + cmake_build check
34 > +}
35 > diff --git a/games-arcade/oshu/oshu-9999.ebuild b/games-arcade/oshu/oshu-9999.ebuild
36 > index 84d415b3c11..f394d808178 100644
37 > --- a/games-arcade/oshu/oshu-9999.ebuild
38 > +++ b/games-arcade/oshu/oshu-9999.ebuild
39 > @@ -32,10 +32,6 @@ RDEPEND="
40 >
41 > DEPEND="${RDEPEND}"
42 >
43 > -# Doesn't build executable needed for the test
44 > -# https://github.com/fmang/oshu/issues/87
45 > -RESTRICT="test"
46 > -
47 > src_prepare() {
48 > if use osu-skin; then
49 > eapply "${FILESDIR}/oshu-2.0.0-use_unpacked_osu-skin.patch"
50 > @@ -53,3 +49,7 @@ src_configure() {
51 >
52 > cmake_src_configure
53 > }
54 > +
55 > +src_test() {
56 > + cmake_build check
57 > +}

Attachments

File name MIME type
signature.asc application/pgp-signature