Re: [gentoo-proxy-maint] [PATCH v4] net-nntp/tin: add 2.6.2

[Joonas Niilola]

On 14.1.2023 11.48, Anna Vyalkova wrote:
> In this update:
> * New: NNTPS support with different backends (openssl by default)
> * New: PCRE2 support (enabled by default)
> * Enable local news support
> * Add missing virtual/libiconv dependency
> * Add missing sys-devel/gettext bdep
> * Drop net-mail/metamail optfeature dep (treecleaned)
> * Export BUILD_* variables
>


Hey,

sorry that I failed to see this yesterday, but could we rework the whole
ssl logic in this ebuild? I just remembered we shouldn't use
REQUIRED_USE to choose an ssl implementation, but instead prioritize it
via use flag selection. See https://bugs.gentoo.org/781908. This was
better documented when libressl was around, and truthfully hasn't been
as much of a problem ever since libressl was removed.

So I'd suggest something like this:
RDEPEND="...
	ssl? (
		gnutls? ( net-libs/gnutls:= )
		!gnutls (
			libtls? ( dev-libs/libretls:= )
			!libtls? ( dev-libs/openssl:= )
		)
	)
..."

src_configure() {
	...

	if use ssl; then
		if use gnutls; then
			myeconfargs+=( --with-nntps=gnutls )
		elif ! use gnutls && use libtls; then
			myeconfargs+=( --with-nntps=libtls )
		else
			myeconfargs+=( --with-nntps=openssl )
		fi
	fi
	...
}