Gentoo Archives: gentoo-proxy-maint

From: Joonas Niilola <juippis@g.o>
To: gentoo-proxy-maint@l.g.o
Subject: Re: [gentoo-proxy-maint] [PATCH] net-news/rssguard: add 3.9.2
Date: Wed, 07 Jul 2021 05:21:27
Message-Id: b71ec095-17b1-34fb-bd4d-52df5e42d498@gentoo.org
In Reply to: [gentoo-proxy-maint] [PATCH] net-news/rssguard: add 3.9.2 by Anna Vyalkova
1 Hey,
2
3 thanks for the contribution!
4
5 On 27.6.2021 16.21, Anna Vyalkova wrote:
6 > diff --git a/net-news/rssguard/metadata.xml b/net-news/rssguard/metadata.xml
7 > index 0728c0b6e44..9dc740407c2 100644
8 > --- a/net-news/rssguard/metadata.xml
9 > +++ b/net-news/rssguard/metadata.xml
10 > @@ -1,7 +1,14 @@
11 > <?xml version="1.0" encoding="UTF-8"?>
12 > <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
13 > <pkgmetadata>
14 > - <!-- maintainer-needed -->
15 > + <maintainer type="person" proxied="yes">
16 > + <email>cyber+gentoo@×××××.in</email>
17 > + <name>Anna</name>
18 > + </maintainer>
19 > + <maintainer type="project" proxied="proxy">
20 > + <email>proxy-maint@g.o</email>
21 > + <name>Proxy Maintainers</name>
22 > + </maintainer>
23 > <upstream>
24 > <remote-id type="github">martinrotter/rssguard</remote-id>
25 > </upstream>
26
27 We'd like to see a bit more longevity and more contributions before
28 adding "new" people as maintainers. You can still contribute of course.
29
30 > diff --git a/net-news/rssguard/rssguard-3.9.2.ebuild b/net-news/rssguard/rssguard-3.9.2.ebuild
31 > new file mode 100644
32 > index 00000000000..75c52810613
33 > --- /dev/null
34 > +++ b/net-news/rssguard/rssguard-3.9.2.ebuild
35 > +
36 > +src_prepare() {
37 > + default
38 > +
39 > + ebegin 'Sedding pri/install.pri to install to $(get_libdir)'
40 > + if grep -q 'lib.path = $$quote($$PREFIX/lib/)' pri/install.pri; then
41 > + sed -i \
42 > + -e 's:lib.path = $$quote($$PREFIX/lib/):lib.path = $$quote($$PREFIX/'$(get_libdir)'/):' \
43 > + pri/install.pri || die
44 > + eend
45 > + else
46 > + eend 1
47 > + eerror 'grep for lib.path = $$quote($$PREFIX/lib/) failed'
48 > + die 'find out what changed and update the ebuild'
49 > + fi
50 > +}
51
52 I know this is present in the previous ebuild, but do we need this check
53 really? You can sed the install.pri file if that hardcoded lib dir still
54 exists. To me this looks more like "internal notes" for the previous
55 maintainer than something that should exist in the ebuild for everyone else.
56
57 -- juippis

Attachments

File name MIME type
OpenPGP_signature.asc application/pgp-signature

Replies

Subject Author
[gentoo-proxy-maint] [PATCH v2] net-news/rssguard: add 3.9.2 Anna Vyalkova <cyber+gentoo@×××××.in>