Re: [gentoo-proxy-maint] [PATCH 1/2] app-shells/mksh: USE=static now uses the system libc

[Haelwenn (lanodan) Monnier]

Thanks for the review,

[2019-10-22 12:25:19+0200] Michał Górny:
> On Thu, 2019-09-19 at 19:47 +0200, Haelwenn (lanodan) Monnier wrote:
> > +src_compile() {
> > +	tc-export CC
> > +	if use static; then export LDSTATIC="-static"; fi
>
> use static && ...
>
> Also, what's the purpose of this anyway?  I mean, I can understand
> having busybox static so you could use it with broken libc.  But what's
> the use for static mksh?

Well, I don't know how far busybox sh have gone but mksh is more 
feature-complete and has a manpage so you know what to expect (which I 
find mandatory if you end up with keyboard working but no output), one 
thing I'm seeing for example is that busybox sh doesn't have is 
brace-expansion, which I find quite useful to avoid repeating yourself.

And going to address the nitpicks & fixes to be done after sending this 
email.