Archives
Archives
| From: | "Hasan ÇALIŞIR" <hasan.calisir@×××××××.com> | ||
|---|---|---|---|
| To: | Joonas Niilola <juippis@g.o> | ||
| Cc: | gentoo-proxy-maint@l.g.o | ||
| Subject: | Re: [gentoo-proxy-maint] [PATCH] net-firewall/ufw: warn about possible conflicts | ||
| Date: | Mon, 16 Aug 2021 20:48:15 | ||
| Message-Id: | aad02c1b-de26-4e63-b3ba-13aac722b6bd@email.android.com | ||
| In Reply to: | Re: [gentoo-proxy-maint] [PATCH] net-firewall/ufw: warn about possible conflicts by Joonas Niilola |
||
| 1 | I thought @has_version package names needs single quotes (or at least quotes). So used double quotes for expansion of variable. If this is not a case your modifications are ok for me. if has_version 'package' Thank you Joonas. 16 A��u 2021 09:35 tarihinde Joonas Niilola <juippis@g.o> yazd��:
|
| 2 | |
| 3 | > Warn about applications that may interfere with ufw. |
| 4 | |
| 5 | > |
| 6 | |
| 7 | > Package-Manager: Portage-3.0.20, Repoman-3.0.2 |
| 8 | |
| 9 | > Signed-off-by: Hasan ��ALI��IR <hasan.calisir@×××××××.com> |
| 10 | |
| 11 | > --- |
| 12 | |
| 13 | > net-firewall/ufw/ufw-0.36.ebuild | 21 +++++++++++++++++++++ |
| 14 | |
| 15 | > 1 file changed, 21 insertions(+) |
| 16 | |
| 17 | > |
| 18 | |
| 19 | > diff --git a/net-firewall/ufw/ufw-0.36.ebuild b/net-firewall/ufw/ufw-0.36.ebuild |
| 20 | |
| 21 | > index ca3e55bb0fe..0da5a40cfa5 100644 |
| 22 | |
| 23 | > --- a/net-firewall/ufw/ufw-0.36.ebuild |
| 24 | |
| 25 | > +++ b/net-firewall/ufw/ufw-0.36.ebuild |
| 26 | |
| 27 | > @@ -166,6 +166,27 @@ pkg_postinst() { |
| 28 | |
| 29 | > local print_check_req_warn |
| 30 | |
| 31 | > print_check_req_warn=false |
| 32 | |
| 33 | > |
| 34 | |
| 35 | > + local found=() |
| 36 | |
| 37 | > + local apps=("${CATEGORY}/arno-iptables-firewall" |
| 38 | |
| 39 | > + "${CATEGORY}/ferm" |
| 40 | |
| 41 | > + "${CATEGORY}/firehol" |
| 42 | |
| 43 | > + "${CATEGORY}/firewalld" |
| 44 | |
| 45 | > + "${CATEGORY}/ipkungfu") |
| 46 | |
| 47 | > + |
| 48 | |
| 49 | > + for exe in "${apps[@]}" |
| 50 | |
| 51 | > + do |
| 52 | |
| 53 | > + if has_version ''"${exe}"''; then |
| 54 | |
| 55 | > + found+=( "${exe}" ) |
| 56 | |
| 57 | > + fi |
| 58 | |
| 59 | > + done |
| 60 | |
| 61 | > + |
| 62 | |
| 63 | > + if [ -n "$found" ]; then |
| 64 | |
| 65 | > + echo |
| 66 | |
| 67 | > + ewarn "WARNING: Detected other firewall applications:" |
| 68 | |
| 69 | > + ewarn "${found[@]}" |
| 70 | |
| 71 | > + ewarn "If enabled, these applications may interfere with ufw!" |
| 72 | |
| 73 | > + fi |
| 74 | |
| 75 | > + |
| 76 | |
| 77 | > if [[ -z "${REPLACING_VERSIONS}" ]]; then |
| 78 | |
| 79 | > echo |
| 80 | |
| 81 | > elog "To enable ufw, add it to boot sequence and activate it:" |
| 82 | |
| 83 | > |
| 84 | |
| 85 | Merged, thanks! I bashified the function a bit in a separate commit. |
| 86 | |
| 87 | |
| 88 | |
| 89 | I saw you had a Github PR for this too. You don't have to duplicate the |
| 90 | |
| 91 | patches, we do get notifications from Github likewise. |
| 92 | |
| 93 | |
| 94 | |
| 95 | -- juippis |
| 96 | |
| 97 | |
| 98 | |
| 99 | |
| 100 | |