Re: [gentoo-proxy-maint] [PATCH v2] net-nntp/tin: add 2.6.2

[Joonas Niilola]

I've merged your rssguard contributions, thanks! Some problems with tin
below:

On 12.1.2023 12.32, Anna Vyalkova wrote:
> In this episode:
>
>  net-nntp/tin/Manifest         |   1 +
>  net-nntp/tin/metadata.xml     |  19 +++---
>  net-nntp/tin/tin-2.6.2.ebuild | 108 ++++++++++++++++++++++++++++++++++
>  3 files changed, 120 insertions(+), 8 deletions(-)
>  create mode 100644 net-nntp/tin/tin-2.6.2.ebuild
>
> +
> +src_configure() {
> +	tc-export AR CC RANLIB
> +	tc-export_build_env
> +
> +	local myeconfargs=(
> +		$(use_enable cancel-locks) $(use_with cancel-locks canlock)

Can we single-line this please?

> +		$(use_enable debug)
> +		$(use_enable gpg pgp-gpg)
> +		$(use_enable nls)
> +		$(use_with pcre2 pcre2-config)
> +		$(use_with !pcre2 pcre "${ESYSROOT}"/usr)
> +		$(use_with socks5 socks) $(use_with socks5)

This too. I don't mind if you separate these from the others via
newlines, e.g.

  $(use_enable cancel-locks)
  $(use_with cancel-locks canlock)

  $(use_enable debug)
  $(use_enable gpg pgp-gpg)
  $(use_enable nls)
  ...

but this current way was surprisingly hard to read (since I've never
seen such being used).

> +		--disable-mime-strict-charset
> +		--enable-nntp-only
> +		--enable-prototypes
> +		--with-coffee # easter egg :)
> +		--with-nntp-default-server="${TIN_DEFAULT_SERVER:-${NNTPSERVER:-news.gmane.io}}"
> +		--with-screen=ncursesw
> +	)
> +

I had a build failure with
USE="cancel-locks gnutls sasl socks5 ssl -debug -gpg -libtls -nls
-openssl -pcre2":

>>> Install net-nntp/tin-2.6.2 into
/var/tmp/portage/net-nntp/tin-2.6.2/image
make -j32 DESTDIR=/var/tmp/portage/net-nntp/tin-2.6.2/image install
make[1]: Entering directory
'/var/tmp/portage/net-nntp/tin-2.6.2/work/tin-2.6.2/src'
mkdir -p /var/tmp/portage/net-nntp/tin-2.6.2/image/usr/bin
make[2]: Entering directory
'/var/tmp/portage/net-nntp/tin-2.6.2/work/tin-2.6.2/src'
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./nntps.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./sigfile.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./signal.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./strftime.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./string.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./tags.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./tcurses.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./tmpfile.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./thread.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./version.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./wildmat.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I/usr/include
 -DLOCALEDIR=\"/usr/share/locale\" -I../include   -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -D_XOPEN_SOURCE_EXTENDED
-I/usr/include/libcanlock-3 -march=native -O2 -pipe
-frecord-gcc-switches  -c ./xref.c
./nntps.c: In function 'tintls_open':
./nntps.c:281:53: error: 'verification_func' undeclared (first use in
this function)
  281 |         gnutls_session_set_verify_function(client,
&verification_func);
      |
^~~~~~~~~~~~~~~~~
./nntps.c:281:53: note: each undeclared identifier is reported only once
for each function it appears in
make[2]: *** [Makefile:301: nntps.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory
'/var/tmp/portage/net-nntp/tin-2.6.2/work/tin-2.6.2/src'
make[1]: *** [Makefile:417: install] Error 2
make[1]: Leaving directory
'/var/tmp/portage/net-nntp/tin-2.6.2/work/tin-2.6.2/src'
make: *** [Makefile:415: install] Error 2
 * ERROR: net-nntp/tin-2.6.2::gentoo failed (install phase):
 *   emake failed

Could you take a look? It's happening in install phase which is a bit weird.



-- juippis