From: Mike Gilbert <floppym@gentoo.org>
To: "Tomáš Chvátal" <tomas.chvatal@gmail.com>
Cc: python@gentoo.org, gentoo-python <gentoo-python@lists.gentoo.org>
Subject: [gentoo-python] Re: eclass patch to fix test rdepend
Date: Fri, 29 Jun 2012 14:15:33 -0400 [thread overview]
Message-ID: <CAJ0EP437WMZkU=fuF74xtAVE2Vp6UP4aCsmoRSVKvb4q3eN+WA@mail.gmail.com> (raw)
In-Reply-To: <CA+NrkpfoPzNKznVsh1_UCkyOeXp_51-3pWses5GKeAdJj9ZsuQ@mail.gmail.com>
On Fri, Jun 29, 2012 at 8:04 AM, Tomáš Chvátal <tomas.chvatal@gmail.com> wrote:
> Hi guys,
>
> I have package that uses python only during the test phase -> test
> conditional needed.
>
> Eclass currently adds the use conditional to depend and rdepend so I
> would propose two choices
> 1) detect some set of build only useflags, like the test and skip
> rdepend assignment on them
>
> Index: python.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/python.eclass,v
> retrieving revision 1.155
> diff -u -b -B -r1.155 python.eclass
> --- python.eclass 9 Jun 2012 10:01:19 -0000 1.155
> +++ python.eclass 29 Jun 2012 12:03:37 -0000
> @@ -247,10 +247,10 @@
>
> if [[ "${#_PYTHON_ATOMS[@]}" -gt 1 ]]; then
> DEPEND+="${DEPEND:+ }${USE_flag}${USE_flag:+?
> ( }|| ( ${_PYTHON_ATOMS[@]} )${USE_flag:+ )}"
> - RDEPEND+="${RDEPEND:+
> }${USE_flag}${USE_flag:+? ( }|| ( ${_PYTHON_ATOMS[@]} )${USE_flag:+
> )}"
> + [[ ${USE_flag} == test ]] ||
> RDEPEND+="${RDEPEND:+ }${USE_flag}${USE_flag:+? ( }|| (
> ${_PYTHON_ATOMS[@]} )${USE_flag:+ )}"
> else
> DEPEND+="${DEPEND:+ }${USE_flag}${USE_flag:+?
> ( }${_PYTHON_ATOMS[@]}${USE_flag:+ )}"
> - RDEPEND+="${RDEPEND:+
> }${USE_flag}${USE_flag:+? ( }${_PYTHON_ATOMS[@]}${USE_flag:+ )}"
> + [[ ${USE_flag} == test ]] ||
> RDEPEND+="${RDEPEND:+ }${USE_flag}${USE_flag:+? (
> }${_PYTHON_ATOMS[@]}${USE_flag:+ )}"
> fi
> else
> die "Invalid syntax of PYTHON_DEPEND"
>
>
> 2) provide something like PYTHON_DEPEND_ONLY variable.
>
> You write the patch.
>
> Please let me know what you guys decide to do as i have to atler my
> ebuild if you decide to go with number two.
>
> Cheers
>
> Tom
Arfrever has a patch implementing PYTHON_BDEPEND (build-time only
deps). Nobody has cared enough to apply it.
parent reply other threads:[~2012-06-29 18:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CA+NrkpfoPzNKznVsh1_UCkyOeXp_51-3pWses5GKeAdJj9ZsuQ@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ0EP437WMZkU=fuF74xtAVE2Vp6UP4aCsmoRSVKvb4q3eN+WA@mail.gmail.com' \
--to=floppym@gentoo.org \
--cc=gentoo-python@lists.gentoo.org \
--cc=python@gentoo.org \
--cc=tomas.chvatal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox