Gentoo Archives: gentoo-python

From: Mike Gilbert <floppym@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-python <gentoo-python@l.g.o>
Subject: Re: [gentoo-python] [PATCH] python-single-r1: add python_gen_* functions
Date: Sun, 28 Dec 2014 20:17:54
Message-Id: CAJ0EP40qVrNsa7e4EHX5NsiFmsD2dc7+eRG6rteaW5TN2BdttA@mail.gmail.com
In Reply to: [gentoo-python] [PATCH] python-single-r1: add python_gen_* functions by "Michał Górny"
1 On Sun, Dec 28, 2014 at 12:41 PM, Michał Górny <mgorny@g.o> wrote:
2 > Hi,
3 >
4 > A quick patch that adds python_gen_usedep, python_gen_useflags
5 > and python_gen_cond_dep. It's pretty much copy-paste from python-r1
6 > with the small changes necessary for python-single-r1 :).
7 >
8 > Please review quickly so that we can fill in the API gaps.
9 >
10
11 I happened to spot an error in the description of python_gen_usedep:
12
13 # Remember to escape or quote the patterns to premature evaluation as a file
14 # name glob.
15
16 It is missing the word "prevent" before "premature".
17
18 Otherwise, it looks ok to me.