[gentoo-python] Re: [gentoo-commits] gentoo-x86 commit in dev-python/logilab-common: logilab-common-0.59.1.ebuild ChangeLog

[Mike Gilbert]

On Tue, Jun 18, 2013 at 10:55 AM, Ian Delaney (idella4)
<idella4@g.o> wrote:
> idella4     13/06/18 14:55:23
>
>   Modified:             logilab-common-0.59.1.ebuild ChangeLog
>   Log:
>   add py3.3 support
>
>   (Portage version: 2.1.11.63/cvs/Linux x86_64, signed Manifest commit with key 0xB8072B0D)
>
> Revision  Changes    Path
> 1.2                  dev-python/logilab-common/logilab-common-0.59.1.ebuild
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-python/logilab-common/logilab-common-0.59.1.ebuild?rev=1.2&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-python/logilab-common/logilab-common-0.59.1.ebuild?rev=1.2&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-python/logilab-common/logilab-common-0.59.1.ebuild?r1=1.1&r2=1.2
>
> Index: logilab-common-0.59.1.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/dev-python/logilab-common/logilab-common-0.59.1.ebuild,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- logilab-common-0.59.1.ebuild        22 Apr 2013 07:18:10 -0000      1.1
> +++ logilab-common-0.59.1.ebuild        18 Jun 2013 14:55:23 -0000      1.2
> @@ -1,10 +1,10 @@
>  # Copyright 1999-2013 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/dev-python/logilab-common/logilab-common-0.59.1.ebuild,v 1.1 2013/04/22 07:18:10 patrick Exp $
> +# $Header: /var/cvsroot/gentoo-x86/dev-python/logilab-common/logilab-common-0.59.1.ebuild,v 1.2 2013/06/18 14:55:23 idella4 Exp $
>
>  EAPI=5
>  # broken with python3.3, bug #449276
> -PYTHON_COMPAT=( python{2_6,2_7,3_2} pypy{1_9,2_0} )
> +PYTHON_COMPAT=( python{2_6,2_7,3_2,3_3} pypy{1_9,2_0} )
>

Why did you choose to ignore the comment above telling you that the
package is broken with python3.3?

It seems pretty clear that this was not tested properly; the pytest
command immediately dies with the same error that is listed in the bug
report.

Also, since logilab-common is broken with python3.3, that breaks astng
and pylint, which you also updated.