[gentoo-python] Re: [PATCH 1/3] Support making distutils-r1 deps and phases optional.

[Mike Gilbert]

On 01/20/2013 05:18 AM, Michał Górny wrote:
> If a particular package uses distutils part only conditionally
> (e.g. with USE=python), you can do something like:
>
> 	DISTUTILS_OPTIONAL=1
> 	RDEPEND="python? ( ${PYTHON_DEPS} )"
> 	src_compile() { cd python; use python && distutils-r1_src_compile; }
> 	src_test() { cd python; use python && distutils-r1_src_test; }
> 	src_install() { cd python; use python && distutils-r1_src_install; }
> ---
>  gx86/eclass/distutils-r1.eclass | 22 +++++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.eclass
> index 6a062ae..80734c5 100644
> --- a/gx86/eclass/distutils-r1.eclass
> +++ b/gx86/eclass/distutils-r1.eclass
> @@ -54,18 +54,34 @@ case "${EAPI:-0}" in
>  		;;
>  esac
>
> +# @ECLASS-VARIABLE: DISTUTILS_OPTIONAL
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# If set to a non-null value, distutils part in the ebuild will
> +# be considered optional. No dependencies will be added and no phase
> +# functions will be exported.
> +#
> +# If you enable DISTUTILS_OPTIONAL, you have to set proper dependencies
> +# for your package (using ${PYTHON_DEPS}) and to either call
> +# distutils-r1 default phase functions or call the build system
> +# manually.
> +
>  if [[ ! ${_DISTUTILS_R1} ]]; then
>
>  inherit eutils multiprocessing python-r1
>
>  fi
>
> -EXPORT_FUNCTIONS src_prepare src_configure src_compile src_test src_install
> +if [[ ! ${DISTUTILS_OPTIONAL} ]]; then
> +	EXPORT_FUNCTIONS src_prepare src_configure src_compile src_test src_install
> +fi
>
>  if [[ ! ${_DISTUTILS_R1} ]]; then
>
> -RDEPEND=${PYTHON_DEPS}
> -DEPEND=${PYTHON_DEPS}
> +if [[ ! ${DISTUTILS_OPTIONAL} ]]; then
> +	RDEPEND=${PYTHON_DEPS}
> +	DEPEND=${PYTHON_DEPS}
> +fi
>
>  # @ECLASS-VARIABLE: DISTUTILS_JOBS
>  # @DEFAULT_UNSET
>

Looks ok.