Re: [gentoo-python] Re: [PATCH 2/8] Clean up python_replicate_script().

[Michał Górny]

Dnia 2013-09-15, o godz. 13:11:21
Mike Gilbert <floppym@g.o> napisał(a):

> On Fri, Sep 13, 2013 at 2:58 PM, Michał Górny <mgorny@g.o> wrote:
> > ---
> >  gx86/eclass/python-r1.eclass | 30 ++++++++++++------------------
> >  1 file changed, 12 insertions(+), 18 deletions(-)
> >
> > diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
> > index 6994952..e006744 100644
> > --- a/gx86/eclass/python-r1.eclass
> > +++ b/gx86/eclass/python-r1.eclass
> > @@ -741,28 +741,22 @@ python_export_best() {
> >  python_replicate_script() {
> >         debug-print-function ${FUNCNAME} "${@}"
> >
> > -       local suffixes=()
> > -
> > -       _add_suffix() {
> > -               suffixes+=( "${EPYTHON}" )
> > -       }
> > -       python_foreach_impl _add_suffix
> > -       debug-print "${FUNCNAME}: suffixes = ( ${suffixes[@]} )"
> > -
> > -       local f suffix
> > -       for suffix in "${suffixes[@]}"; do
> > -               for f; do
> > -                       local newf=${f}-${suffix}
> > -
> > -                       debug-print "${FUNCNAME}: ${f} -> ${newf}"
> > -                       cp "${f}" "${newf}" || die
> > +       _python_replicate_script() {
> > +               local f
> > +               for f in "${files[@]}"; do
> > +                       cp -p "${f}" "${f}-${EPYTHON}" || die
> >                 done
> > +               _python_rewrite_shebang "${EPYTHON}" \
> > +                       "${files[@]/%/-${EPYTHON}}"
> > +       }
> >
> > -               _python_rewrite_shebang "${suffix}" "${@/%/-${suffix}}"
> > -       done
> > +       local files=( "${@}" )
> > +       python_foreach_impl _python_replicate_script
>
> Why are we creating a new array variable here? Why not just pass $@ to
> _python_replicate script as arguments?

It's because python_foreach_impl likes to verbose and prints "${@}"
starting with first non-underline arg. Passing files out-of-argv
is the simplest way of avoiding verbose output.


-- 
Best regards,
Michał Górny