[gentoo-python] Re: [PATCH 1/2] python_doscript() to install Python scripts.

[Mike Gilbert]

On Wed, Nov 14, 2012 at 2:54 PM, Michał Górny <mgorny@g.o> wrote:
> ---
>  gx86/eclass/python-r1.eclass | 66 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
>
> diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
> index 6d4eb33..44103a8 100644
> --- a/gx86/eclass/python-r1.eclass
> +++ b/gx86/eclass/python-r1.eclass
> @@ -611,3 +611,69 @@ python_replicate_script() {
>                 _python_ln_rel "${ED}"/usr/bin/python-exec "${f}" || die
>         done
>  }
> +
> +# @ECLASS-VARIABLE: python_scriptroot
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# The current script destination for python_doscript(). The path
> +# is relative to the installation root (${ED}).
> +#
> +# When unset, ${DESTTREE}/bin (/usr/bin by default) will be used.
> +#
> +# Can be set indirectly through the python_scriptinto() function.
> +#
> +# Example:
> +# @CODE
> +# src_install() {
> +#   local python_scriptroot=${GAMES_BINDIR}
> +#   python_foreach_impl python_doscript foo
> +# }
> +# @CODE
> +
> +# @FUNCTION: python_scriptinto
> +# @USAGE: <new-path>
> +# @DESCRIPTION:
> +# Set the current scriptroot. The new value will be stored
> +# in the 'python_scriptroot' environment variable. The new value need
> +# be relative to the installation root (${ED}).
> +#
> +# Alternatively, you can set the variable directly.
> +python_scriptinto() {
> +       debug-print-function ${FUNCNAME} "${@}"
> +
> +       python_scriptroot=${1}
> +}
> +
> +# @FUNCTION: python_doscript
> +# @USAGE: <files>...
> +# @DESCRIPTION:
> +# Install the given scripts into current python_scriptroot,
> +# for the current Python implementation (${EPYTHON}).
> +#
> +# All specified files must start with a 'python' shebang. The shebang
> +# will be converted, the file will be renamed to be EPYTHON-suffixed
> +# and a wrapper will be installed in place of the original name.
> +python_doscript() {
> +       debug-print-function ${FUNCNAME} "${@}"
> +
> +       [[ ${EPYTHON} ]] || die 'No Python implementation set (EPYTHON is null).'
> +
> +       local d=${python_scriptroot:-${DESTTREE}/bin}
> +       local INSDESTTREE INSOPTIONS
> +
> +       insinto "${d}"
> +       insopts -m755
> +

Could possibly use exeinto/newexe instead here.

> +       local f
> +       for f; do
> +               local oldfn=${f##*/}
> +               local newfn=${oldfn}-${EPYTHON}
> +
> +               debug-print "${FUNCNAME}: ${oldfn} -> ${newfn}"
> +               newins "${f}" "${newfn}"
> +               _python_rewrite_shebang "${D}/${d}/${newfn}"
> +
> +               # install the wrapper
> +               _python_ln_rel "${ED}"/usr/bin/python-exec "${D}/${d}/${oldfn}" || die
> +       done
> +}
> --
> 1.8.0
>

Looks fine overall.