[gentoo-python] Re: [PATCH 5/5] Re-enable split logs, now in python*_foreach_impl().

[Mike Gilbert]

On 02/21/2013 05:10 PM, Michał Górny wrote:
> This provides the split logs accessible to every Python package, not
> only ones using distutils.
> ---
>  gx86/eclass/python-r1.eclass | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/gx86/eclass/python-r1.eclass b/gx86/eclass/python-r1.eclass
> index 09e6417..1b26513 100644
> --- a/gx86/eclass/python-r1.eclass
> +++ b/gx86/eclass/python-r1.eclass
> @@ -620,8 +620,17 @@ python_foreach_impl() {
>  			local BUILD_DIR=${bdir%%/}-${impl}
>  			export EPYTHON PYTHON
>
> -			einfo "${EPYTHON}: running ${@}"
> -			"${@}"
> +			einfo "${EPYTHON}: running ${@}" \
> +				| tee -a "${T}/build-${EPYTHON}.log"
> +
> +			# _python_parallel() does redirection internally.
> +			# note: this is a hidden API to avoid writing python_foreach_impl
> +			# twice. do *not* even think of using it anywhere else.
> +			if [[ ${1} == _python_parallel ]]; then
> +				"${@}"
> +			else
> +				"${@}" 2>&1 | tee -a "${T}/build-${EPYTHON}.log"
> +			fi
>  			lret=${?}
>
>  			[[ ${ret} -eq 0 && ${lret} -ne 0 ]] && ret=${lret}
> @@ -655,7 +664,8 @@ python_parallel_foreach_impl() {
>  	_python_parallel() {
>  		(
>  			multijob_child_init
> -			"${@}"
> +			"${@}" 2>&1 | tee -a "${T}/build-${EPYTHON}.log"
> +			exit ${PIPESTATUS[0]}
>  		) &
>  		multijob_post_fork
>  	}
>

Why do we call "exit ${PIPESTATUS[0]}"? I have never seen that before.