Gentoo Archives: gentoo-python

From: Mike Gilbert <floppym@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-python <gentoo-python@l.g.o>, Gentoo Python Project <python@g.o>
Subject: [gentoo-python] Re: [PATCH 5/8] distutils-r1: disable sub-root merging.
Date: Sat, 14 Sep 2013 22:16:38
Message-Id: CAJ0EP410oF328MQQC2mMTksx0qMrjytkzD+_3JhJo8vEjzHMdQ@mail.gmail.com
In Reply to: [gentoo-python] [PATCH 5/8] distutils-r1: disable sub-root merging. by "Michał Górny"
1 On Fri, Sep 13, 2013 at 2:58 PM, Michał Górny <mgorny@g.o> wrote:
2 > The sub-roots are no longer necessary since we're installing scripts to
3 > per-impl directories initially.
4 > ---
5 > gx86/eclass/distutils-r1.eclass | 9 +++------
6 > 1 file changed, 3 insertions(+), 6 deletions(-)
7 >
8 > diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.eclass
9 > index 7102c58..5fcb55e 100644
10 > --- a/gx86/eclass/distutils-r1.eclass
11 > +++ b/gx86/eclass/distutils-r1.eclass
12 > @@ -476,9 +476,7 @@ distutils-r1_python_install() {
13 > addpredict "$(python_get_sitedir)"
14 > addpredict /usr/lib/portage/pym
15 >
16 > - local root=${D}/_${EPYTHON}
17 > - [[ ${DISTUTILS_SINGLE_IMPL} ]] && root=${D}
18 > - flags+=( --root="${root}" )
19 > + flags+=( --root="${D}" )
20 >
21 > if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
22 > local PYTHON_SCRIPTDIR
23 > @@ -488,13 +486,12 @@ distutils-r1_python_install() {
24 >
25 > esetup.py install "${flags[@]}" "${@}"
26 >
27 > - if [[ -d ${root}$(python_get_sitedir)/tests ]]; then
28 > + if [[ -d ${D}$(python_get_sitedir)/tests ]]; then
29 > die "Package installs 'tests' package, file collisions likely."
30 > fi
31 >
32 > if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
33 > - _distutils-r1_wrap_scripts "${root}"
34 > - multibuild_merge_root "${root}" "${D}"
35 > + _distutils-r1_wrap_scripts "${D}"
36 > fi
37 > }
38 >
39 > --
40 > 1.8.3.2
41 >
42
43 I believe this patch causes a race condition which causes
44 java-config's ebuild to fail.
45
46 running install_data
47 running install_egg_info
48 Writing /tmp/portage/dev-java/java-config-2.2.0/image/usr/lib64/python2.7/site-packages/java_config-
49 2.2.0-py2.7.egg-info
50 error: /tmp/portage/dev-java/java-config-2.2.0/image//usr/share/java-config-2/config/:
51 File exists

Replies