Re: [gentoo-qa] QA confusion: Upstream qa issues -> failing to install

[Markos Chandras]

On Wed, Aug 25, 2010 at 01:42:12PM +0200, Thilo Bangert wrote:
> Hi guys,
>
> trying to install openssh on the dev profile one is greated with this
> bugger:
>
>  * QA Notice: Package has poor programming practices which may compile
>  *            fine but exhibit random runtime failures.
>  * closefromtest.c:46: warning: implicit declaration of function
> ‘closefrom’
>
This is a rather common bug for 64bit arches

See relevant patches [1][2]

>  * Please do not file a Gentoo bug and instead report the above QA
>  * issues directly to the upstream developers of this software.
>  * Homepage: http://www.openssh.org/
>  * ERROR: net-misc/openssh-5.5_p1-r2 failed:
>  *   install aborted due to poor programming practices shown above
>  *
>  * Call stack:
>  *   misc-functions.sh, line 847:  Called install_qa_check
>  *   misc-functions.sh, line 539:  Called die
>  * The specific snippet of code:
>  *                              hasq stricter ${FEATURES} && die "install
> aborted due to" \
>  *
>  * If you need support, post the output of 'emerge --info =net-
> misc/openssh-5.5_p1-r2',
>  * the complete build log and the output of 'emerge -pqv =net-
> misc/openssh-5.5_p1-r2'.
>  * The complete build log is located at '/var/tmp/portage/net-
> misc/openssh-5.5_p1-r2/temp/build.log'.
>  * The ebuild environment file is located at '/var/tmp/portage/net-
> misc/openssh-5.5_p1-r2/temp/environment'.
>  * S: '/var/tmp/portage/net-misc/openssh-5.5_p1-r2/work/openssh-5.5p1'
>
> This looks really really weird. On the one hand we are saying: "Its a QA
> issue but upstream should fix it." followed by "It so broke, we wont let
> you install it."
This is not only related to stricter but also related to CFLAGS ( having -ggdb
and -Wall, produce same failures for me even if I don't use stricter )

Diego, any ideas why this happens? -Wall & -ggdb produce extra output on
warning that makes portage abort because of that? I always wondered why this
is happening.
>
> Perhaps qa warnings that fail when FEATURES="stricter", should not point
> to upstream for the fix. Instead we should take responsibility for these
> and consequently allow these bugs to linger in our bugzilla.
>
> What do you tink?
> kind regards
> Thilo

[1]:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-analyzer/nagios-plugins/files/nagios-plugins-1.4.14-implicit-pointer-conversion.patch?view=log
[2]:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-editors/xemacs/files/xemacs-21.4.22-implicit-pointer-conversion.patch?view=log

-- 
Markos Chandras (hwoarang)
Gentoo Linux Developer
Web: http://hwoarang.silverarrow.org
Key ID: 441AC410
Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410