Re: [gentoo-science] ntl bump

[François Bissey]

Hi Thomas,
> On 10/07/2015, at 18:23, Thomas Kahle <tomka@g.o> wrote:
>
> Hi,
>
> On 10/07/15 09:07, François Bissey wrote:
>> On 07/09/15 11:12, François Bissey wrote:
>>> Hi,
>>>
>>> Resurrecting the thread from the dead. Sage is moving
>>> to ntl-9.2.0 plus a couple of patches (of which upstream is
>>> aware and will do something about sooner rather than later).
>>>
>>> We have patch for singular-3 cherry-picked from the singular-4
>>> main github tree.
>>>
>>> All matter of details here
>>> http://trac.sagemath.org/ticket/18845
>>>
>>
>> And upstream released ntl-9.3.0 and sage is moving to that.
>> And it is now in the sage-on-gentoo overlay to be used for
>> sage 6.8 when it comes out. It is free of patch originating
>> from sage! Yeah!
>
> Hi,
>
> I'd like to put 9.3 in the main tree, but there are some problems
> with the ebuild. There are lots of unecessary "|| die" and the
> patch "${FILESDIR}"/${PN}-9.2.0-singular.patch is also not there.
> Is this patch necessary for the main tree?  What does it do?

I reckon you are right about the number of “|| die” they are not necessary
in EAPI 5.
Still the points you raise are interesting because they are all present in your
ntl-9.0.2.ebuild from which the 9.3.0 ebuild is based. The only thing is that
patches have been rebased on the new code and I added a “src_test” phase
because I think your handling of “test” is wrong - it is at least wrong the
way I have been using the ebuild command directly while I write them.

* As noted the singular patch is for compatibility with singular (at least 
version 3, I do not know if it is with version 4). Without it singular won’t
build if I remember correctly.

I will clean up those “die” for you.

François