From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4E2F415808B for ; Sat, 12 Mar 2022 11:14:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 51314E095F; Sat, 12 Mar 2022 11:14:55 +0000 (UTC) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E9DB2E095F for ; Sat, 12 Mar 2022 11:14:54 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id z12-20020a17090ad78c00b001bf022b69d6so10400334pju.2 for ; Sat, 12 Mar 2022 03:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:subject:message-id:mime-version:content-description :content-disposition; bh=Igteul+DB5NC8arF5ofLstJPS2yIazl/0/hm6FzHmcQ=; b=TTOdM4jSNRIEyfyyldfe8kwb1FLu+Bbzt8Tzu4PCxZJCe3+/bljbMHb5yxy4G3IAHn l6FeQhxYyYDEfE9dEOz5rhbF7r96KTuAThFELsx+NRJBx2agvSSv1hvTIYNEW4VJtVow YBLjzCoZRcQ0y7Dcc/nq9ZnNbjQ7ZwSY9+9NOukqrSR5oYGK6+gyP4qMaEqV8ywvcbq4 z/dl2tvdfdKWyTA3AArFyw9ZbLg5hDWfrlqDenZzzmWubJtKotx0ZqnJl/Y7yM6Pj+rx JZgWRywqoYJ98BNSEhNd3DuPtX5uwHst49jWtpdjEtpQ8fznkCIiO1OgR3LVrw9veO87 ouEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-description:content-disposition; bh=Igteul+DB5NC8arF5ofLstJPS2yIazl/0/hm6FzHmcQ=; b=75ructBsRJv3wIpuLWlCphIcOkz3bT0QfL8fhwNaph8pB8Kts4YoprowjAFvHm7jW8 Py6oO0CDOqv6p0WB9t7FBEfSNaKiwnr7QsmE+coWX5AJo8QWKi29ZA4BiuUNXKOUGvMj KR6bOAGcLA8LDQJRv+pVmX12z5A6u1vY0OZjQVlRgpPFySayeujXCSAdxo47LNuirMe4 wcBfFdZD8Ca+fHW0CLUP6Uzgf4n8Ofj0e4hs5k78HEcFQLRnWrBywIf/ii/Crdwkx1mJ Bw2gawoAVPzHF/7mmGarRJpfc6538HagwoEV4hVgp3R9ylqsKdj7EnTFbqdpSuafiRpS A/8w== X-Gm-Message-State: AOAM532b0vIRnYlCvRAQiIcyNqxJBz63DaSeCgfuFclk6Mwnuk6hoBbt yH2rSdxxPWaLw3w07sEV+eB0l2Y3eaShDQ== X-Google-Smtp-Source: ABdhPJySp/bOC/dgitxSPFILOqFgQd2KGotuMAg8lOwkcqG/7bkGuJv/gaFl55CLVLmnkzkFxjO0JQ== X-Received: by 2002:a17:903:2c7:b0:151:a932:f1f0 with SMTP id s7-20020a17090302c700b00151a932f1f0mr15028946plk.130.1647083693637; Sat, 12 Mar 2022 03:14:53 -0800 (PST) Received: from gmail.com ([150.242.150.77]) by smtp.gmail.com with ESMTPSA id f20-20020a056a00229400b004f74434eae4sm13487025pfe.153.2022.03.12.03.14.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Mar 2022 03:14:53 -0800 (PST) From: brahmajit.xyz@gmail.com X-Google-Original-From: gogo@gmail.com Date: Sat, 12 Mar 2022 16:44:54 +0530 To: gentoo-soc@lists.gentoo.org Subject: [gentoo-soc] [GSoC] [WIP PATCH] build mp3info on musl profile Message-ID: <20220312111454.sz237tee76jtjzfw@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-soc@lists.gentoo.org Reply-to: gentoo-soc@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Description:  Content-Disposition: inline X-Archives-Salt: 0e265a73-0932-434a-accd-5a62512e8abf X-Archives-Hash: 0e1fadb50aeba6d5dc3660b446f53bca This patch fixes bug 828919. Initially package mp3info could not be built with musl with error `uint undeclared`. The fix is to move to `usinged int` from `uint` (thanks to *sam_*). The extra `-lintfo` is because it was failing to build with only `-lncurses`, I'm guessing this due to incorrect USE flags on my system. I'm hoping to get started with this simple patch and get reviews from maintainers. --- diff --git a/Makefile b/Makefile index e4e632d..e970f05 100644 --- a/Makefile +++ b/Makefile @@ -43,7 +43,7 @@ RM = /bin/rm INSTALL = /usr/bin/install -c STRIP = strip -LIBS = -lncurses +LIBS = -lncurses -ltinfo CC = gcc CFLAGS = -g -O2 -Wall diff --git a/mp3tech.c b/mp3tech.c index a1ae218..710491d 100644 --- a/mp3tech.c +++ b/mp3tech.c @@ -279,7 +279,7 @@ char *header_mode(mp3header *h) { } int sameConstant(mp3header *h1, mp3header *h2) { - if((*(uint*)h1) == (*(uint*)h2)) return 1; + if((*(unsigned int*)h1) == (*(unsigned int*)h2)) return 1; if((h1->version == h2->version ) && (h1->layer == h2->layer ) && ---