| 1 |
On Fri, Oct 15, 2010 at 7:27 PM, Albert Hopkins <marduk@×××××××××××.org> wrote: |
| 2 |
> On Fri, 2010-10-15 at 07:35 -0700, Mark Knecht wrote: |
| 3 |
>> File "/usr/lib64/portage/pym/_emerge/actions.py", line 2134, in |
| 4 |
>> action_sync |
| 5 |
>> "//" + user_name + ip + port + "/", 1)) |
| 6 |
>> TypeError: cannot concatenate 'str' and 'int' objects |
| 7 |
> |
| 8 |
> This is a bug... shuld be more something like: |
| 9 |
> |
| 10 |
> uris.append(syncuri.replace( |
| 11 |
> "//%s%s%s/" % (user_name, hostname, port), |
| 12 |
> "//%s%s%s/" % (user_name, ip, port), 1)) |
| 13 |
> |
| 14 |
> Probably needs to be reported. |
| 15 |
> |
| 16 |
> |
| 17 |
> |
| 18 |
> |
| 19 |
|
| 20 |
Coding against PEP8 is not a bug. I guess devs find string |
| 21 |
concatenation more handy and maintainable. |
| 22 |
|
| 23 |
The bug was about the addrinfos data gotten from the server. I thought |
| 24 |
the response of possibly down rsync server was not handled well, which |
| 25 |
is why I offered to change rsync server, but the actual problem was |
| 26 |
caused by assuming that IPv6 is supported on the machine. |
| 27 |
|
| 28 |
-- |
| 29 |
Fatih |
Archives