| 1 |
On Tue, Aug 22, 2017 at 6:34 AM, Nils Freydank <nils.freydank@××××××.de> wrote: |
| 2 |
> Am Dienstag, 22. August 2017, 09:01:07 CEST schrieb Raffaele Belardi: |
| 3 |
>> […] |
| 4 |
>> > [1] https://bugs.gentoo.org/show_bug.cgi?id=604430 |
| 5 |
>> > [2] https://bugs.gentoo.org/show_bug.cgi?id=575232 |
| 6 |
>> |
| 7 |
>> Just as follow up, inspired by [2] I fixed the mythtv build issue by |
| 8 |
>> adding #include <sys/sysmacros.h> to videosource.cpp and continuing the |
| 9 |
>> build with ebuild instead of emerge. |
| 10 |
> Great! In general, to improve Gentoo a bit further, you could create a patch |
| 11 |
> at this point, test applying it via /etc/portage/patches/ and add it to the |
| 12 |
> bugtracker (or paste it here or in IRC asking someone to paste it in your |
| 13 |
> name) ;-) |
| 14 |
> |
| 15 |
|
| 16 |
Per the comment I made in the bug, if you're going to patch, I'd use |
| 17 |
upstream's patch - the commit for 0.28 is: |
| 18 |
https://github.com/MythTV/mythtv/commit/b012ff0f6b284969183863d42a6a14eb77ed0a1d |
| 19 |
|
| 20 |
In general it is ALWAYS better to use the upstream patch. Plus if you |
| 21 |
need to get a Gentoo dev to commit it for you you'll get less |
| 22 |
push-back that way if you reference it in a bug. |
| 23 |
|
| 24 |
> |
| 25 |
> BTW, mythtv has no maintainer, might you be interested in a proxied |
| 26 |
> maintainership? |
| 27 |
> |
| 28 |
|
| 29 |
I'd encourage somebody to step up and do this - I no longer use it and |
| 30 |
MythTV is one of those packages that you really need to use if you |
| 31 |
want to maintain it (hardware/etc, plus a fair bit of work). |
| 32 |
|
| 33 |
If somebody steps up and wants tips please do feel free to ping me, |
| 34 |
and I suspect cardoe would also be willing. |
| 35 |
|
| 36 |
In general though upstream maintains git branches for each of their |
| 37 |
releases under fixes/ that track stuff like this. This commit was in |
| 38 |
fixes/0.28. These are stable branches and very unlikely to break |
| 39 |
anything - and this was the basis of all the updates within a release |
| 40 |
on Gentoo previously. The minor releases like 0.28.1 are just tagged |
| 41 |
versions off of these branches - 0.28 plus all the fixes up to that |
| 42 |
point in time is basically the same as 0.28.1. The ebuild is designed |
| 43 |
to make it easy to pull these in - I see that cardoe pointed it at |
| 44 |
github so in theory you can just change the hash to the new head and |
| 45 |
it will probably pull in all the fixes. |
| 46 |
|
| 47 |
They're up to 0.29 now. That isn't in the 0.28 fixes branch, and |
| 48 |
might need a bit more testing. |
| 49 |
|
| 50 |
-- |
| 51 |
Rich |
Archives