Gentoo Archives: gnap-dev

From: "josé Alberto Suárez López" <bass@g.o>
To: gnap-dev@l.g.o
Subject: Re: [gnap-dev] [PATCH] Custom GNAP TEMPDIR in gnap_make
Date: Thu, 21 Jun 2007 13:41:59
Message-Id: 1182433308.15159.27.camel@supercoco
In Reply to: Re: [gnap-dev] [PATCH] Custom GNAP TEMPDIR in gnap_make by Philipp Riegger
1 El jue, 21-06-2007 a las 15:40 +0300, Philipp Riegger escribió:
2 > On 21.06.2007, at 15:02, josé Alberto Suárez López wrote:
3 >
4 > > nice idea :)
5 > >
6 > > El jue, 21-06-2007 a las 14:48 +0300, Philipp Riegger escribió:
7 > >> Good day.
8 > >>
9 > >> I though it might be nice to be able to tell gnap_make which tempdir
10 > >> to use. I can think of 2 scenarios where this will make sense:
11 >
12 > I'd like to discuss 2 points i'm not quite sure about.
13 >
14 > 1) keeptemp: Should this be an extra option (-K) or should this be
15 > triggered by my introduces custom tempdir option (-T)?
16
17 i prefer an extra option, so maybe is better to keep this kind of
18 "advanced" options in commons.conf
19
20 > 2) My option is quite strange since "usually" you give a tempdir
21 > like /var/tmp and the tool uses a subdir of that e.g. /var/tmp/gnap-
22 > lsdfnsdf. My approach uses the given dir directly, this is kind of
23 > not straight forward. Furthermore, if somebody uses a environment
24 > variable TEMPDIR and -T is not used, the alternative execution path
25 > is also used.
26 >
27 > Some possibilities what to do:
28 >
29 > To fix the environment thing, TEMPDIR can be set to '' before parsing
30 > command line arguments. As an alternative we could use the GNAP*
31 > namespace and rename it to GNAPTEMP or GNAPTEMPDIR. This would be
32 > easier than setting all sensitive variables to '' and if somebody
33 > messes with that namespace, it's not our fault.
34
35 We must use the GNAP namespace.
36
37 > To fix 2) we could use TEMPDIR/gnap or TEMPDIR/gnap-VERSIONSTAMP in
38 > the -T case. anything against this?
39
40 VERSIONSTAMP must be used ever.
41
42 >
43 > Thoughts about 1): If no overlays are used, the tempdir is quite
44 > small. If overlays are used, then it is bigger, but the data created
45 > during the snapshot creation is simply the portage snapshot and the
46 > overlays on top and can be found in the catalyst tempdir. So... the
47 > big data is never really needed and it is available at another place
48 > and the small data is the important one and does not hurt much.
49 >
50 > Still: Should we introduce a new command like option or create some
51 > logic when to delete what and when not? I would prefer 2.
52
53 i prefer 2 too, so maybe we can guide this logic in cmmons.conf
54
55 >
56 > Philipp
57
58 --
59 gnap-dev@g.o mailing list