| 1 |
On Sun, Dec 29, 2013 at 09:32:35PM -0800, Brian Dolbec wrote: |
| 2 |
> On Sun, 2013-12-29 at 20:02 -0800, W. Trevor King wrote: |
| 3 |
> > That's a long subject ;). How about: |
| 4 |
> > |
| 5 |
> > Add "local_overlay" to configdefaults |
| 6 |
> > |
| 7 |
> > Fixes commit 463d98f (modules/generic_stage_target.py: Use a |
| 8 |
> > 'local_overlay' setting instead of hard-coding '/usr/local/portage', |
| 9 |
> > 2012-12-19). |
| 10 |
> > |
| 11 |
> > That gives you both a concise summary and a more detailed body without |
| 12 |
> > making wrapping in `git log --oneline`. |
| 13 |
> |
| 14 |
> First: I'm not feeling well, so please don't take this too personally. |
| 15 |
|
| 16 |
No problem. I don't think there's a particular hurry to address |
| 17 |
everything either, so if you want to just let things cook for a week |
| 18 |
and then get back to them when you're feeling better, that's certainly |
| 19 |
fine with me. |
| 20 |
|
| 21 |
> I committed exactly what you had in the previous review |
| 22 |
> (copy/paste). I knew it was too long, but when I tried breaking it |
| 23 |
> up, git puked on it. so I thought what the hell and left it. I |
| 24 |
> wasn't going to "waste" more time on it. |
| 25 |
|
| 26 |
I've pushed: |
| 27 |
|
| 28 |
git://tremily.us/catalyst.git pending |
| 29 |
|
| 30 |
with the commit-message cleanups I've suggested on v2. If you want me |
| 31 |
to help figure out why Git didn't like your earlier attempt, just let |
| 32 |
me know. |
| 33 |
|
| 34 |
Cheers, |
| 35 |
Trevor |
| 36 |
|
| 37 |
-- |
| 38 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 39 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives