Gentoo Archives: gentoo-catalyst

From: Brian Dolbec <dolsen@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 3/6] Fixes commit 463d98f (modules/generic_stage_target.py: Use a 'local_overlay' setting instead of hard-coding '/usr/local/portage', 2012-12-19).Add "local_overlay" to configdefaults.
Date: Mon, 30 Dec 2013 05:33:02
Message-Id: 1388381555.24088.63.camel@big_daddy.dol-sen.ca
In Reply to: Re: [gentoo-catalyst] [PATCH 3/6] Fixes commit 463d98f (modules/generic_stage_target.py: Use a 'local_overlay' setting instead of hard-coding '/usr/local/portage', 2012-12-19).Add "local_overlay" to configdefaults. by "W. Trevor King"
1 On Sun, 2013-12-29 at 20:02 -0800, W. Trevor King wrote:
2 > That's a long subject ;). How about:
3 >
4 > Add "local_overlay" to configdefaults
5 >
6 > Fixes commit 463d98f (modules/generic_stage_target.py: Use a
7 > 'local_overlay' setting instead of hard-coding '/usr/local/portage',
8 > 2012-12-19).
9 >
10 > That gives you both a concise summary and a more detailed body without
11 > making wrapping in `git log --oneline`.
12 >
13 > Cheers,
14 > Trevor
15 >
16
17 First: I'm not feeling well, so please don't take this too personally.
18
19 I committed exactly what you had in the previous review (copy/paste). I
20 knew it was too long, but when I tried breaking it up, git puked on it.
21 so I thought what the hell and left it. I wasn't going to "waste" more
22 time on it.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies